From dad30672d9acf24f2ae14f3d3a3513441d2da048 Mon Sep 17 00:00:00 2001 From: Luke Wilde Date: Fri, 13 Dec 2024 18:24:19 +0000 Subject: [PATCH] LibWeb/WebGL: Return GL_INVALID_ENUM for unknown buffer parameter names --- .../CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp index bf1e797db3a..64be39b8b74 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp @@ -274,7 +274,9 @@ static void generate_get_buffer_parameter(SourceGenerator& generator) generator.appendln(R"~~~( default: - TODO(); + dbgln("Unknown WebGL buffer parameter name: {:x}", pname); + set_error(GL_INVALID_ENUM); + return JS::js_null(); })~~~"); }