mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-06 08:09:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS+LibUnicode: Port Intl.ListFormat to UTF-16 strings

Browse source
This commit is contained in:
Timothy Flynn 2025-07-23 14:42:57 -04:00 • committed by Andreas Kling
commit db2148b44a
Notes: github-actions[bot] 2025-07-24 08:41:31 +00:00
7 changed files with 39 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Runtime/Intl/DurationFormat.cpp
View file

@ -731,13 +731,13 @@ Vector<DurationFormatPart> list_format_parts(VM& vm, DurationFormat const& durat
auto list_format = construct_list_format(vm, duration_format, list_format_options);
// 7. Let strings be a new empty List.
Vector<String> strings;
Vector<Utf16String> strings;
strings.ensure_capacity(partitioned_parts_list.size());
// 8. For each element parts of partitionedPartsList, do
for (auto const& parts : partitioned_parts_list) {
// a. Let string be the empty String.
StringBuilder string;
StringBuilder string(StringBuilder::Mode::UTF16);
// b. For each Record { [[Type]], [[Value]], [[Unit]] } part in parts, do
for (auto const& part : parts) {
@ -746,7 +746,7 @@ Vector<DurationFormatPart> list_format_parts(VM& vm, DurationFormat const& durat
}
// c. Append string to strings.
strings.unchecked_append(MUST(string.to_string()));
strings.unchecked_append(string.to_utf16_string());
}
// 9. Let formattedPartsList be CreatePartsFromList(lf, strings).
@ -786,7 +786,7 @@ Vector<DurationFormatPart> list_format_parts(VM& vm, DurationFormat const& durat
VERIFY(list_part.type == "literal"sv);
// ii. Append the Record { [[Type]]: "literal", [[Value]]: listPart.[[Value]], [[Unit]]: empty } to flattenedPartsList.
flattened_parts_list.append({ .type = "literal"sv, .value = move(list_part.value), .unit = {} });
flattened_parts_list.append({ .type = "literal"sv, .value = list_part.value.to_utf8_but_should_be_ported_to_utf16(), .unit = {} });
}
}