mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-06-21 01:31:55 +00:00
LibWeb: Initialize static web strings during main-thread VM creation
These are currently initialized in a [[gnu::constructor]], which has a weird initialization order. These constructors are invoked before main() and, incidentally, before any user-defined default constructors of the static strings they are initializing. This will become an issue when these strings are ported to FlyString, which has a user-defined default constructor. In that scenario, when the FlyString constructor is executed after the [[gnu::constructor]], the strings will be "reset" to the empty string. Instead of relying on a non-standard compiler extension here, let's just initialize these strings explicitly during main-thread VM creation, as this now happens in WebContent's main().
This commit is contained in:
parent
0d0b87fd46
commit
db2ba5f1d9
Notes:
sideshowbarker
2024-07-17 22:55:25 +09:00
Author: https://github.com/trflynn89
Commit: db2ba5f1d9
Pull-request: https://github.com/SerenityOS/serenity/pull/17914
Reviewed-by: https://github.com/gmta ✅
Reviewed-by: https://github.com/linusg ✅
19 changed files with 74 additions and 27 deletions
|
@ -7,6 +7,7 @@
|
|||
#pragma once
|
||||
|
||||
#include <AK/DeprecatedFlyString.h>
|
||||
#include <AK/Error.h>
|
||||
|
||||
namespace Web::HTML::EventNames {
|
||||
|
||||
|
@ -64,4 +65,6 @@ namespace Web::HTML::EventNames {
|
|||
ENUMERATE_HTML_EVENTS
|
||||
#undef __ENUMERATE_HTML_EVENT
|
||||
|
||||
ErrorOr<void> initialize_strings();
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue