mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-20 15:09:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Make LengthBox hold LengthPercentageOrAuto

Browse source 
Not every user of this requires an `auto` state, but most do.

This has quite a big diff but most of that is mechanical:
LengthPercentageOrAuto has `resolved_or_auto()` instead of `resolved()`,
and `to_px_or_zero()` instead of `to_px()`, to make their output
clearer.
This commit is contained in:
Sam Atkins 2025-09-01 12:51:52 +01:00
commit dd122e2f74
Notes: github-actions[bot] 2025-09-04 12:32:43 +00:00
17 changed files with 199 additions and 215 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibWeb/Layout/GridFormattingContext.cpp
View file

@ -1819,20 +1819,20 @@ void GridFormattingContext::resolve_items_box_metrics(GridDimension dimension)
CSSPixels containing_block_width = containing_block_size_for_item(item, GridDimension::Column);
if (dimension == GridDimension::Column) {
item.used_values.padding_right = computed_values.padding().right().to_px(grid_container(), containing_block_width);
item.used_values.padding_left = computed_values.padding().left().to_px(grid_container(), containing_block_width);
item.used_values.padding_right = computed_values.padding().right().to_px_or_zero(grid_container(), containing_block_width);
item.used_values.padding_left = computed_values.padding().left().to_px_or_zero(grid_container(), containing_block_width);
item.used_values.margin_right = computed_values.margin().right().to_px(grid_container(), containing_block_width);
item.used_values.margin_left = computed_values.margin().left().to_px(grid_container(), containing_block_width);
item.used_values.margin_right = computed_values.margin().right().to_px_or_zero(grid_container(), containing_block_width);
item.used_values.margin_left = computed_values.margin().left().to_px_or_zero(grid_container(), containing_block_width);
item.used_values.border_right = computed_values.border_right().width;
item.used_values.border_left = computed_values.border_left().width;
} else {
item.used_values.padding_top = computed_values.padding().top().to_px(grid_container(), containing_block_width);
item.used_values.padding_bottom = computed_values.padding().bottom().to_px(grid_container(), containing_block_width);
item.used_values.padding_top = computed_values.padding().top().to_px_or_zero(grid_container(), containing_block_width);
item.used_values.padding_bottom = computed_values.padding().bottom().to_px_or_zero(grid_container(), containing_block_width);
item.used_values.margin_top = computed_values.margin().top().to_px(grid_container(), containing_block_width);
item.used_values.margin_bottom = computed_values.margin().bottom().to_px(grid_container(), containing_block_width);
item.used_values.margin_top = computed_values.margin().top().to_px_or_zero(grid_container(), containing_block_width);
item.used_values.margin_bottom = computed_values.margin().bottom().to_px_or_zero(grid_container(), containing_block_width);
item.used_values.border_top = computed_values.border_top().width;
item.used_values.border_bottom = computed_values.border_bottom().width;
@ -2179,10 +2179,10 @@ void GridFormattingContext::layout_absolutely_positioned_element(Box const& box)
box_state.border_right = box.computed_values().border_right().width;
box_state.border_top = box.computed_values().border_top().width;
box_state.border_bottom = box.computed_values().border_bottom().width;
box_state.padding_left = box.computed_values().padding().left().to_px(grid_container(), grid_area_rect.width());
box_state.padding_right = box.computed_values().padding().right().to_px(grid_container(), grid_area_rect.width());
box_state.padding_top = box.computed_values().padding().top().to_px(grid_container(), grid_area_rect.width());
box_state.padding_bottom = box.computed_values().padding().bottom().to_px(grid_container(), grid_area_rect.width());
box_state.padding_left = box.computed_values().padding().left().to_px_or_zero(grid_container(), grid_area_rect.width());
box_state.padding_right = box.computed_values().padding().right().to_px_or_zero(grid_container(), grid_area_rect.width());
box_state.padding_top = box.computed_values().padding().top().to_px_or_zero(grid_container(), grid_area_rect.width());
box_state.padding_bottom = box.computed_values().padding().bottom().to_px_or_zero(grid_container(), grid_area_rect.width());
compute_width_for_absolutely_positioned_element(box, available_space);