mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-02 23:56:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibGfx: Ensure capacity for glyph runs in TextLayout

Browse source 
We can reserve the capacity for new glyph runs since we already know the
glyph count.
This commit is contained in:
Jelle Raaijmakers 2025-06-13 16:50:47 +02:00 • committed by Alexander Kalenik
commit dd4d7d0939
Notes: github-actions[bot] 2025-06-13 15:32:24 +00:00
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibGfx/TextLayout.cpp
View file

@ -84,9 +84,9 @@ RefPtr<GlyphRun> shape_text(FloatPoint baseline_start, float letter_spacing, Utf
auto* positions = hb_buffer_get_glyph_positions(buffer, &glyph_count); auto* positions = hb_buffer_get_glyph_positions(buffer, &glyph_count);
Vector<Gfx::DrawGlyph> glyph_run; Vector<Gfx::DrawGlyph> glyph_run;
glyph_run.ensure_capacity(glyph_count);
FloatPoint point = baseline_start; FloatPoint point = baseline_start;
for (size_t i = 0; i < glyph_count; ++i) { for (size_t i = 0; i < glyph_count; ++i) {
auto position = point auto position = point
- FloatPoint { 0, font.pixel_metrics().ascent } - FloatPoint { 0, font.pixel_metrics().ascent }
+ FloatPoint { positions[i].x_offset, positions[i].y_offset } / text_shaping_resolution; + FloatPoint { positions[i].x_offset, positions[i].y_offset } / text_shaping_resolution;
@ -98,10 +98,9 @@ RefPtr<GlyphRun> shape_text(FloatPoint baseline_start, float letter_spacing, Utf
if (i != (glyph_count - 1)) if (i != (glyph_count - 1))
point.translate_by(letter_spacing, 0); point.translate_by(letter_spacing, 0);
} }
auto run = adopt_ref(*new Gfx::GlyphRun(move(glyph_run), font, text_type, point.x() - baseline_start.x()));
hb_buffer_reset(buffer); hb_buffer_reset(buffer);
return run;
return adopt_ref(*new Gfx::GlyphRun(move(glyph_run), font, text_type, point.x() - baseline_start.x()));
} }
float measure_text_width(Utf8View const& string, Gfx::Font const& font, ShapeFeatures const& features) float measure_text_width(Utf8View const& string, Gfx::Font const& font, ShapeFeatures const& features)