mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-19 15:32:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibDevTools: Associate node actors with a DOM node identifier

Browse source 
This is a prepatory commit to be able to handle DOM mutations. Once a
node actor is created, the DOM node it is created for must continue to
be associated with the same actor even after DOM mutations. This change
stores an identifier on the node actor, and only creates new actors when
an actor for a node does not exist.
This commit is contained in:
Timothy Flynn 2025-03-06 19:49:27 -05:00 • committed by Andreas Kling
parent ee88edc750
commit ddea67034f
Notes: github-actions[bot] 2025-03-08 00:28:03 +00:00
6 changed files with 80 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibDevTools/Actors/NodeActor.cpp
View file

@ -11,13 +11,31 @@
namespace DevTools {
NonnullRefPtr<NodeActor> NodeActor::create(DevToolsServer& devtools, String name, WeakPtr<WalkerActor> walker)
NodeIdentifier NodeIdentifier::for_node(JsonObject const& node)
{
return adopt_ref(*new NodeActor(devtools, move(name), move(walker)));
NodeIdentifier identifier;
identifier.pseudo_element = node.get_integer<UnderlyingType<Web::CSS::Selector::PseudoElement::Type>>("pseudo-element"sv).map([](auto value) {
VERIFY(value < to_underlying(Web::CSS::Selector::PseudoElement::Type::KnownPseudoElementCount));
return static_cast<Web::CSS::Selector::PseudoElement::Type>(value);
});
if (identifier.pseudo_element.has_value())
identifier.id = node.get_integer<Web::UniqueNodeID::Type>("parent-id"sv).value();
else
identifier.id = node.get_integer<Web::UniqueNodeID::Type>("id"sv).value();
return identifier;
}
NodeActor::NodeActor(DevToolsServer& devtools, String name, WeakPtr<WalkerActor> walker)
NonnullRefPtr<NodeActor> NodeActor::create(DevToolsServer& devtools, String name, NodeIdentifier node_identifier, WeakPtr<WalkerActor> walker)
{
return adopt_ref(*new NodeActor(devtools, move(name), move(node_identifier), move(walker)));
}
NodeActor::NodeActor(DevToolsServer& devtools, String name, NodeIdentifier node_identifier, WeakPtr<WalkerActor> walker)
: Actor(devtools, move(name))
, m_node_identifier(move(node_identifier))
, m_walker(move(walker))
{
}