mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-31 21:29:06 +00:00
LibWeb: Invalidate style if url changed in HTMLHyperlinkElementUtils
Previously, <a> elements were frequently invalidated because `set_the_url()` was called by `reinitialize_url()`, which is a preparation step in every HTMLHyperlinkElementUtils function. As a result, styles were unnecessarily invalidated each time any of these functions were invoked without changing the URL.
This commit is contained in:
parent
84b69c2387
commit
de062e4d2c
Notes:
github-actions[bot]
2025-01-10 14:36:34 +00:00
Author: https://github.com/kalenikaliaksandr
Commit: de062e4d2c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3213
Reviewed-by: https://github.com/gmta ✅
1 changed files with 6 additions and 3 deletions
|
@ -28,13 +28,18 @@ void HTMLHyperlinkElementUtils::reinitialize_url() const
|
||||||
// https://html.spec.whatwg.org/multipage/links.html#concept-hyperlink-url-set
|
// https://html.spec.whatwg.org/multipage/links.html#concept-hyperlink-url-set
|
||||||
void HTMLHyperlinkElementUtils::set_the_url()
|
void HTMLHyperlinkElementUtils::set_the_url()
|
||||||
{
|
{
|
||||||
|
ScopeGuard invalidate_style_if_needed = [old_url = m_url, this] {
|
||||||
|
if (m_url != old_url) {
|
||||||
|
hyperlink_element_utils_element().invalidate_style(DOM::StyleInvalidationReason::HTMLHyperlinkElementHrefChange);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
// 1. Set this element's url to null.
|
// 1. Set this element's url to null.
|
||||||
m_url = {};
|
m_url = {};
|
||||||
|
|
||||||
// 2. If this element's href content attribute is absent, then return.
|
// 2. If this element's href content attribute is absent, then return.
|
||||||
auto href_content_attribute = hyperlink_element_utils_href();
|
auto href_content_attribute = hyperlink_element_utils_href();
|
||||||
if (!href_content_attribute.has_value()) {
|
if (!href_content_attribute.has_value()) {
|
||||||
hyperlink_element_utils_element().invalidate_style(DOM::StyleInvalidationReason::HTMLHyperlinkElementHrefChange);
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -44,8 +49,6 @@ void HTMLHyperlinkElementUtils::set_the_url()
|
||||||
// 4. If url is not failure, then set this element's url to url.
|
// 4. If url is not failure, then set this element's url to url.
|
||||||
if (url.is_valid())
|
if (url.is_valid())
|
||||||
m_url = move(url);
|
m_url = move(url);
|
||||||
|
|
||||||
hyperlink_element_utils_element().invalidate_style(DOM::StyleInvalidationReason::HTMLHyperlinkElementHrefChange);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-origin
|
// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-origin
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue