mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-28 05:07:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb+WebDriver: Convert WebDriver session flags to an enumeration

Browse source 
Rather than a list of strings, this will be easier to deal with as a
bitwise enumeration.
This commit is contained in:
Timothy Flynn 2025-02-07 11:09:28 -05:00 • committed by Tim Flynn
commit de34351ba8
Notes: github-actions[bot] 2025-02-10 16:35:17 +00:00
5 changed files with 20 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/WebDriver/Capabilities.cpp
View file

@ -263,7 +263,7 @@ static bool matches_platform_name(StringView requested_platform_name, StringView
}
// https://w3c.github.io/webdriver/#dfn-matching-capabilities
static JsonValue match_capabilities(JsonObject const& capabilities, ReadonlySpan<StringView> flags)
static JsonValue match_capabilities(JsonObject const& capabilities, SessionFlags flags)
{
static auto browser_name = StringView { BROWSER_NAME, strlen(BROWSER_NAME) }.to_lowercase_string();
static auto platform_name = StringView { OS_STRING, strlen(OS_STRING) }.to_lowercase_string();
@ -294,7 +294,7 @@ static JsonValue match_capabilities(JsonObject const& capabilities, ReadonlySpan
matched_capabilities.set("userAgent"sv, Web::default_user_agent);
// 2. If flags contains "http", add the following entries to matched capabilities:
if (flags.contains_slow("http"sv)) {
if (has_flag(flags, SessionFlags::Http)) {
// "strictFileInteractability"
// Boolean initially set to false, indicating that interactabilty checks will be applied to <input type=file>.
matched_capabilities.set("strictFileInteractability"sv, false);
@ -377,7 +377,7 @@ static JsonValue match_capabilities(JsonObject const& capabilities, ReadonlySpan
}
// https://w3c.github.io/webdriver/#dfn-capabilities-processing
Response process_capabilities(JsonValue const& parameters, ReadonlySpan<StringView> flags)
Response process_capabilities(JsonValue const& parameters, SessionFlags flags)
{
if (!parameters.is_object())
return Error::from_code(ErrorCode::InvalidArgument, "Session parameters is not an object"sv);

9
Libraries/LibWeb/WebDriver/Capabilities.h
View file

@ -6,12 +6,19 @@
#pragma once
#include <AK/EnumBits.h>
#include <AK/Forward.h>
#include <AK/StringView.h>
#include <LibWeb/WebDriver/Response.h>
namespace Web::WebDriver {
enum class SessionFlags {
Default = 0x0,
Http = 0x1,
};
AK_ENUM_BITWISE_OPERATORS(SessionFlags);
// https://w3c.github.io/webdriver/#dfn-page-load-strategy
enum class PageLoadStrategy {
None,
@ -42,6 +49,6 @@ struct LadybirdOptions {
bool headless { false };
};
Response process_capabilities(JsonValue const& parameters, ReadonlySpan<StringView> flags);
Response process_capabilities(JsonValue const& parameters, SessionFlags flags);
}