mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-11 02:29:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWebView: Defer creating services until after application init
Some checks are pending
CI / macOS, arm64, Sanitizer_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
In particular, we need to defer creating the process manager until after
we have decided whether or not to create a UI-specific event loop. If we
create the process manager sooner, its event loop signal registration
does not work, and we don't handle child processes exiting.
This commit is contained in:
Timothy Flynn 2025-06-11 07:32:37 -04:00 • committed by Tim Flynn
commit df0dc32006
Notes: github-actions[bot] 2025-06-11 12:27:34 +00:00
3 changed files with 29 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWebView/Application.h
View file

@ -47,7 +47,7 @@ public:
static CookieJar& cookie_jar() { return *the().m_cookie_jar; }
static ProcessManager& process_manager() { return the().m_process_manager; }
static ProcessManager& process_manager() { return *the().m_process_manager; }
ErrorOr<NonnullRefPtr<WebContentClient>> launch_web_content_process(ViewImplementation&);
@ -142,7 +142,7 @@ private:
OwnPtr<Core::TimeZoneWatcher> m_time_zone_watcher;
OwnPtr<Core::EventLoop> m_event_loop;
ProcessManager m_process_manager;
OwnPtr<ProcessManager> m_process_manager;
bool m_in_shutdown { false };
#if defined(AK_OS_MACOS)