mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 15:49:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Always store ComputedProperties, even if no invalidations
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Before this change, we'd skip storing the new ComputedProperties in
Element::recompute_style() if there was no invalidation needed.

This caused us to lose the information about which properties are
inherited and/or important (which is also carried by ComputedProperties,
but doesn't affect invalidation).

Consequently, we'd then fail to recompute inherited styles, since that
mechanism depends on this data.

The fix is simply to always store the new ComputedProperties.
This commit is contained in:
Andreas Kling 2025-04-12 22:45:25 +02:00 • committed by Andreas Kling
commit e068ff5a5d
Notes: github-actions[bot] 2025-04-12 22:44:44 +00:00
3 changed files with 66 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/DOM/Element.cpp
View file

@ -539,8 +539,7 @@ CSS::RequiredInvalidationAfterStyleChange Element::recompute_style()
auto old_display_is_none = m_computed_properties ? m_computed_properties->display().is_none() : true; auto old_display_is_none = m_computed_properties ? m_computed_properties->display().is_none() : true;
auto new_display_is_none = new_computed_properties->display().is_none(); auto new_display_is_none = new_computed_properties->display().is_none();
if (!invalidation.is_none()) set_computed_properties(move(new_computed_properties));
set_computed_properties(move(new_computed_properties));
if (old_display_is_none != new_display_is_none) { if (old_display_is_none != new_display_is_none) {
play_or_cancel_animations_after_display_property_change(); play_or_cancel_animations_after_display_property_change();

30
Tests/LibWeb/Text/expected/wpt-import/css/css-box/inheritance.txt Normal file
View file

@ -0,0 +1,30 @@
Harness status: OK
Found 24 tests
22 Pass
2 Fail
Pass Property clear has initial value none
Pass Property clear does not inherit
Pass Property float has initial value none
Pass Property float does not inherit
Pass Property margin-bottom has initial value 0px
Pass Property margin-bottom does not inherit
Pass Property margin-left has initial value 0px
Pass Property margin-left does not inherit
Pass Property margin-right has initial value 0px
Pass Property margin-right does not inherit
Pass Property margin-top has initial value 0px
Pass Property margin-top does not inherit
Fail Property margin-trim has initial value none
Fail Property margin-trim does not inherit
Pass Property padding-bottom has initial value 0px
Pass Property padding-bottom does not inherit
Pass Property padding-left has initial value 0px
Pass Property padding-left does not inherit
Pass Property padding-right has initial value 0px
Pass Property padding-right does not inherit
Pass Property padding-top has initial value 0px
Pass Property padding-top does not inherit
Pass Property visibility has initial value visible
Pass Property visibility inherits

35
Tests/LibWeb/Text/input/wpt-import/css/css-box/inheritance.html Normal file
View file

@ -0,0 +1,35 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Inheritance of CSS Box Model properties</title>
<link rel="help" href="https://drafts.csswg.org/css-box-3/#property-index">
<link rel="help" href="https://www.w3.org/TR/CSS2/">
<meta name="assert" content="Properties do not inherit.">
<meta name="assert" content="length-percentage properties have initial value 0.">
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../../css/support/inheritance-testcommon.js"></script>
</head>
<body>
<div id="container">
<div id="target"></div>
</div>
<script>
assert_not_inherited('clear', 'none', 'right');
assert_not_inherited('float', 'none', 'right');
assert_not_inherited('margin-bottom', '0px', '10px');
assert_not_inherited('margin-left', '0px', '10px');
assert_not_inherited('margin-right', '0px', '10px');
assert_not_inherited('margin-top', '0px', '10px');
assert_not_inherited('margin-trim', 'none', 'block');
assert_not_inherited('padding-bottom', '0px', '10px');
assert_not_inherited('padding-left', '0px', '10px');
assert_not_inherited('padding-right', '0px', '10px');
assert_not_inherited('padding-top', '0px', '10px');
assert_inherited('visibility', 'visible', 'collapse');
</script>
</body>
</html>