From e0ecf3b03310f85efb0ddf285a981651a61c01d8 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Fri, 7 Feb 2025 11:57:46 -0500 Subject: [PATCH] LibWeb: Do not reject unknown WebDriver extension capabilities --- Libraries/LibWeb/WebDriver/Capabilities.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Libraries/LibWeb/WebDriver/Capabilities.cpp b/Libraries/LibWeb/WebDriver/Capabilities.cpp index 1442b990197..a824a576d9f 100644 --- a/Libraries/LibWeb/WebDriver/Capabilities.cpp +++ b/Libraries/LibWeb/WebDriver/Capabilities.cpp @@ -174,9 +174,12 @@ static ErrorOr validate_capabilities(JsonValue const& capabil } // -> name is the key of an extension capability - // If name is known to the implementation, let deserialized be the result of trying to deserialize value in an implementation-specific way. Otherwise, let deserialized be set to value. - else if (name == "serenity:ladybird"sv) { - deserialized = TRY(deserialize_as_ladybird_options(value)); + else if (name.contains(':')) { + // If name is known to the implementation, let deserialized be the result of trying to deserialize value in + // an implementation-specific way. Otherwise, let deserialized be set to value. + if (name == "serenity:ladybird"sv) { + deserialized = TRY(deserialize_as_ladybird_options(value)); + } } // -> The remote end is an endpoint node