mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-11 18:50:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

IDLGenerators: Do not generate required dictionary members as Optional

Browse source
This commit is contained in:
devgianlu 2024-12-31 14:48:38 +01:00 • committed by Andrew Kaster
commit e14511468f
Notes: github-actions[bot] 2025-02-05 20:19:57 +00:00
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -945,6 +945,9 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter
bool may_be_null = !optional_default_value.has_value() || parameter.type->is_nullable() || optional_default_value.value() == "null"; bool may_be_null = !optional_default_value.has_value() || parameter.type->is_nullable() || optional_default_value.value() == "null";
// Required dictionary members cannot be null.
may_be_null &= !member.required;
if (member.type->is_string() && optional && may_be_null) { if (member.type->is_string() && optional && may_be_null) {
dictionary_generator.append(R"~~~( dictionary_generator.append(R"~~~(
if (@member_value_name@.has_value()) if (@member_value_name@.has_value())