From e1598233e1c8d8326aa69871dfed85dc5d92f57c Mon Sep 17 00:00:00 2001 From: MINAqwq <84045544+MINAqwq@users.noreply.github.com> Date: Mon, 4 Mar 2024 11:13:17 +0100 Subject: [PATCH] LibCore: Remove unnecessary or invalid write after child remove --- Userland/Libraries/LibCore/EventReceiver.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibCore/EventReceiver.h b/Userland/Libraries/LibCore/EventReceiver.h index 98789257955..b16d77fedbb 100644 --- a/Userland/Libraries/LibCore/EventReceiver.h +++ b/Userland/Libraries/LibCore/EventReceiver.h @@ -134,7 +134,9 @@ public: { if (m_parent) m_parent->remove_child(*this); - m_parent = nullptr; + + // The call to `remove_child` may have deleted the object. + // Do not dereference `this` from this point forward. } template