From e20a887a8db2ff667d06d72df33db2cc170d260c Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Tue, 3 Dec 2024 17:47:14 -0700 Subject: [PATCH] Toolchain: Actually disable vcpkg metrics In the move to a python version of this script, I didn't notice that running the bootstrap script in shell mode precluded it from actually accepting the -disableMetrics argument. Existing vcpkg installs can be un-metrics'd by re-running the bootstrap script with the disable argument, or by adding a vcpkg.disable-metrics file in $VCPKG_ROOT --- Toolchain/BuildVcpkg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Toolchain/BuildVcpkg.py b/Toolchain/BuildVcpkg.py index 3b9e50f36ae..32de99561ff 100755 --- a/Toolchain/BuildVcpkg.py +++ b/Toolchain/BuildVcpkg.py @@ -31,7 +31,7 @@ def main() -> int: subprocess.check_call(args=["git", "checkout", git_rev], cwd=vcpkg_checkout) bootstrap_script = "bootstrap-vcpkg.bat" if os.name == 'nt' else "bootstrap-vcpkg.sh" - subprocess.check_call(args=[vcpkg_checkout / bootstrap_script, "-disableMetrics"], cwd=vcpkg_checkout, shell=True) + subprocess.check_call(args=[vcpkg_checkout / bootstrap_script, "-disableMetrics"], cwd=vcpkg_checkout) return 0