mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-10 01:59:31 +00:00
LibWeb: Handle empty string in lang
attribute
If the attribute value is the empty string `(lang="")`, the language is set to unknown. `lang` attribute higher up in the document tree will no longer be applied to the content of that element.
This commit is contained in:
parent
ff39f6cec5
commit
e2613090ed
Notes:
github-actions[bot]
2024-11-04 12:07:26 +00:00
Author: https://github.com/pbrw
Commit: e2613090ed
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2078
Reviewed-by: https://github.com/AtkinsSJ ✅
5 changed files with 90 additions and 30 deletions
|
@ -0,0 +1 @@
|
|||
OK
|
|
@ -0,0 +1 @@
|
|||
OK
|
25
Tests/LibWeb/Text/input/HTML/lang-attribute-empty-1.html
Normal file
25
Tests/LibWeb/Text/input/HTML/lang-attribute-empty-1.html
Normal file
|
@ -0,0 +1,25 @@
|
|||
<!DOCTYPE html>
|
||||
<html>
|
||||
<head>
|
||||
<style type='text/css'>
|
||||
.test div { width: 50px; }
|
||||
#box:lang(ko) { width: 100px; }
|
||||
</style>
|
||||
</head>
|
||||
<body>
|
||||
<div class="test" lang="ko">
|
||||
<div id="box" lang="">Test</div>
|
||||
</div>
|
||||
</body>
|
||||
<script src="../include.js"></script>
|
||||
<script>
|
||||
asyncTest((done) => {
|
||||
if (document.getElementById('box').offsetWidth == 50) {
|
||||
println("OK");
|
||||
} else {
|
||||
println("FAIL. If an element contains a lang attribute with an empty value, the value of a lang attribute higher up the document tree will no longer be applied to the content of that element.");
|
||||
}
|
||||
done();
|
||||
});
|
||||
</script>
|
||||
</html>
|
25
Tests/LibWeb/Text/input/HTML/lang-attribute-empty-2.html
Normal file
25
Tests/LibWeb/Text/input/HTML/lang-attribute-empty-2.html
Normal file
|
@ -0,0 +1,25 @@
|
|||
<!DOCTYPE html>
|
||||
<html lang="ko">
|
||||
<head>
|
||||
<style type='text/css'>
|
||||
.test div { width: 50px; }
|
||||
#box:lang(ko) { width: 100px; }
|
||||
</style>
|
||||
</head>
|
||||
<body>
|
||||
<div class="test">
|
||||
<div id="box" lang="">Test</div>
|
||||
</div>
|
||||
</body>
|
||||
<script src="../include.js"></script>
|
||||
<script>
|
||||
asyncTest((done) => {
|
||||
if (document.getElementById('box').offsetWidth == 50) {
|
||||
println("OK");
|
||||
} else {
|
||||
println("FAIL. If the meta Content-Language element contains a language declaration but the html element uses an empty lang value, the UA will not recognize the language declared in the meta Content-Language element.");
|
||||
}
|
||||
done();
|
||||
});
|
||||
</script>
|
||||
</html>
|
|
@ -2905,6 +2905,7 @@ void Element::inherit_counters()
|
|||
// https://html.spec.whatwg.org/multipage/dom.html#the-lang-and-xml:lang-attributes
|
||||
Optional<String> Element::lang() const
|
||||
{
|
||||
auto attempt_to_determine_lang_attribute = [&]() -> Optional<String> {
|
||||
// 1. If the node is an element that has a lang attribute in the XML namespace set
|
||||
// Use the value of that attribute.
|
||||
auto maybe_xml_lang = get_attribute_ns(Namespace::XML, HTML::AttributeNames::lang);
|
||||
|
@ -2939,6 +2940,13 @@ Optional<String> Element::lang() const
|
|||
// the language of the node is unknown, and the corresponding language tag is the empty string.
|
||||
// Default locale sounds like a reasonable fallback here.
|
||||
return {};
|
||||
};
|
||||
|
||||
// If the resulting value is the empty string, then it must be interpreted as meaning that the language of the node is explicitly unknown.
|
||||
auto maybe_lang = attempt_to_determine_lang_attribute();
|
||||
if (!maybe_lang.has_value() || maybe_lang->is_empty())
|
||||
return {};
|
||||
return maybe_lang.release_value();
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue