mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 11:36:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use (de)serialization with transfer AOs for structured cloning

Browse source 
This is important, for example, to detach transferred array buffers.
This commit is contained in:
Timothy Flynn 2025-04-17 09:00:36 -04:00
parent de0d225d71
commit e2881ec817
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/HTML/UniversalGlobalScope.cpp
View file

@ -93,19 +93,16 @@ void UniversalGlobalScopeMixin::queue_microtask(WebIDL::CallbackType& callback)
// https://html.spec.whatwg.org/multipage/structured-data.html#dom-structuredclone
WebIDL::ExceptionOr<JS::Value> UniversalGlobalScopeMixin::structured_clone(JS::Value value, StructuredSerializeOptions const& options) const
{
auto& vm = this_impl().vm();
(void)options;
auto& realm = HTML::relevant_realm(this_impl());
// 1. Let serialized be ? StructuredSerializeWithTransfer(value, options["transfer"]).
// FIXME: Use WithTransfer variant of the AO
auto serialized = TRY(structured_serialize(vm, value));
auto serialized = TRY(structured_serialize_with_transfer(realm.vm(), value, options.transfer));
// 2. Let deserializeRecord be ? StructuredDeserializeWithTransfer(serialized, this's relevant realm).
// FIXME: Use WithTransfer variant of the AO
auto deserialized = TRY(structured_deserialize(vm, serialized, relevant_realm(this_impl())));
auto deserialized = TRY(structured_deserialize_with_transfer(serialized, realm));
// 3. Return deserializeRecord.[[Deserialized]].
return deserialized;
return deserialized.deserialized;
}
// https://streams.spec.whatwg.org/#count-queuing-strategy-size-function

4
Tests/LibWeb/Text/expected/wpt-import/streams/readable-byte-streams/enqueue-with-detached-buffer.any.txt
View file

@ -2,5 +2,5 @@ Harness status: OK
Found 1 tests
1 Fail
Fail enqueue after detaching byobRequest.view.buffer should throw
1 Pass
Pass enqueue after detaching byobRequest.view.buffer should throw