mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-30 06:52:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

SQLStudio: Remove (unimplemented) ability to open database storage files

Browse source 
It may be handy to have some sort of storage inspector at some point but
for now, it doesn't make sense to open a database file. So only allow
opening script files, and don't make assumptions on their extension.
This commit is contained in:
Timothy Flynn 2022-12-28 23:22:12 -05:00 • committed by Andreas Kling
parent 690389ae81
commit e3d5b67eaf
Notes: sideshowbarker 2024-07-17 02:26:43 +09:00
3 changed files with 4 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/DevTools/SQLStudio/MainWidget.cpp
View file

@ -352,11 +352,6 @@ void MainWidget::open_script_from_file(LexicalPath const& file_path)
m_tab_widget->set_active_widget(&editor);
}
void MainWidget::open_database_from_file(LexicalPath const&)
{
TODO();
}
bool MainWidget::request_close()
{
auto any_scripts_modified { false };
@ -485,10 +480,7 @@ void MainWidget::drop_event(GUI::DropEvent& drop_event)
continue;
auto lexical_path = LexicalPath(url.path());
if (lexical_path.extension().equals_ignoring_case("sql"sv))
open_script_from_file(lexical_path);
if (lexical_path.extension().equals_ignoring_case("db"sv))
open_database_from_file(lexical_path);
}
}
}

1
Userland/DevTools/SQLStudio/MainWidget.h
View file

@ -25,7 +25,6 @@ public:
void initialize_menu(GUI::Window*);
void open_new_script();
void open_script_from_file(LexicalPath const&);
void open_database_from_file(LexicalPath const&);
bool request_close();

10
Userland/DevTools/SQLStudio/main.cpp
View file

@ -39,18 +39,12 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
return GUI::Window::CloseRequestDecision::StayOpen;
};
auto needs_new_script = true;
if (file_to_open) {
auto path = LexicalPath(file_to_open);
if (path.extension().equals_ignoring_case("sql"sv)) {
main_widget->open_script_from_file(path);
needs_new_script = false;
} else if (path.extension().equals_ignoring_case("db"sv)) {
main_widget->open_database_from_file(path);
}
}
if (needs_new_script)
} else {
main_widget->open_new_script();
}
window->show();
return app->exec();