mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 20:29:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Add and use PrimitiveString::length_in_utf16_code_units

Browse source 
I was investigating an optimization in this area, and while it
didn't seem to have a noticable improvement, it still seems
useful to apply this change.
This commit is contained in:
Shannon Booth 2025-05-04 00:06:34 +12:00 • committed by Andreas Kling
commit e476d21ed0
Notes: github-actions[bot] 2025-05-03 14:19:42 +00:00
5 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibJS/Runtime/StringObject.cpp
View file

@ -42,7 +42,7 @@ void StringObject::initialize(Realm& realm)
auto& vm = this->vm();
Base::initialize(realm);
define_direct_property(vm.names.length, Value(m_string->utf16_string_view().length_in_code_units()), 0);
define_direct_property(vm.names.length, Value(m_string->length_in_utf16_code_units()), 0);
}
void StringObject::visit_edges(Cell::Visitor& visitor)
@ -136,12 +136,9 @@ ThrowCompletionOr<GC::RootVector<Value>> StringObject::internal_own_property_key
auto keys = GC::RootVector<Value> { heap() };
// 2. Let str be O.[[StringData]].
auto str = m_string->utf16_string_view();
// 3. Assert: str is a String.
// 4. Let len be the length of str.
auto length = str.length_in_code_units();
auto length = m_string->length_in_utf16_code_units();
// 5. For each integer i starting with 0 such that i < len, in ascending order, do
for (size_t i = 0; i < length; ++i) {