mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-28 23:39:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Align default “th” and “td” roles with HTML-AAM spec and tests

Browse source 
This change aligns the default roles for “th” and “td” elements with the
requirements in the HTML-AAM spec, and with the corresponding WPT tests
at https://wpt.fyi/results/html-aam/table-roles.html, and with the
behavior in other engines.

Otherwise, without this change, the default role values for “th” and
“td” elements in some cases don’t match the behavior in other engines,
and don’t match the expected results for the corresponding WPT tests.
This commit is contained in:
sideshowbarker 2024-12-07 18:21:31 +09:00 • committed by Andrew Kaster
parent 2d638485a8
commit e49fe384d1
Notes: github-actions[bot] 2024-12-12 00:02:47 +00:00
5 changed files with 252 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

35
Libraries/LibWeb/HTML/HTMLTableCellElement.cpp
View file

@ -196,16 +196,31 @@ WebIDL::Long HTMLTableCellElement::cell_index() const
Optional<ARIA::Role> HTMLTableCellElement::default_role() const
{
// TODO: For td:
// role=cell if the ancestor table element is exposed as a role=table
// role=gridcell if the ancestor table element is exposed as a role=grid or treegrid
// No corresponding role if the ancestor table element is not exposed as a role=table, grid or treegrid
// For th:
// role=columnheader, rowheader or cell if the ancestor table element is exposed as a role=table
// role=columnheader, rowheader or gridcell if the ancestor table element is exposed as a role=grid or treegrid
// No corresponding role if the ancestor table element is not exposed as a role=table, grid or treegrid
// https://www.w3.org/TR/html-aria/#el-td
// https://www.w3.org/TR/html-aria/#el-th
if (local_name() == TagNames::th) {
for (auto const* ancestor = parent_element(); ancestor; ancestor = ancestor->parent_element()) {
// AD-HOC: The ancestor checks here aren’t explicitly defined in the spec, but implicitly follow from what
// the spec does state, and from the physical placement/layout of elements. Also, the el-th and el-th-in-row
// tests at https://wpt.fyi/results/html-aam/table-roles.html require doing these ancestor checks — and
// implementing them causes the behavior to match that of other engines.
// https://w3c.github.io/html-aam/#el-th-columnheader
if (get_attribute(HTML::AttributeNames::scope) == "columnheader" || ancestor->local_name() == TagNames::thead)
return ARIA::Role::columnheader;
// https://w3c.github.io/html-aam/#el-th-rowheader
if (get_attribute(HTML::AttributeNames::scope) == "rowheader" || ancestor->local_name() == TagNames::tbody)
return ARIA::Role::rowheader;
}
}
auto const* table_element = first_ancestor_of_type<HTMLTableElement>();
// https://w3c.github.io/html-aam/#el-td
// https://w3c.github.io/html-aam/#el-th/
// (ancestor table element has table role)
if (table_element->role_or_default() == ARIA::Role::table)
return ARIA::Role::cell;
// https://w3c.github.io/html-aam/#el-td-gridcell
// https://w3c.github.io/html-aam/#el-th-gridcell
// (ancestor table element has grid or treegrid role)
if (first_is_one_of(table_element->role_or_default(), ARIA::Role::grid, ARIA::Role::gridcell))
return ARIA::Role::gridcell;
return {};
}