mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-21 18:00:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Cache the last CSS play-state value on KeyframeEffect

Browse source 
This way we can just leave it alone if the property hasn't changed.
Notably, if the play-state property has been set to 'paused', and then
the user gets the animation with JS and calls .play() on it, it should
start playing despite the play-state property value.
This commit is contained in:
Matthew Olsson 2024-03-26 17:02:27 -07:00 • committed by Andrew Kaster
commit e4dba9d932
Notes: sideshowbarker 2024-07-18 04:46:35 +09:00
2 changed files with 21 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Animations/KeyframeEffect.h
View file

@ -107,6 +107,9 @@ public:
virtual void update_style_properties() override;
Optional<CSS::AnimationPlayState> last_css_animation_play_state() const { return m_last_css_animation_play_state; }
void set_last_css_animation_play_state(CSS::AnimationPlayState state) { m_last_css_animation_play_state = state; }
private:
KeyframeEffect(JS::Realm&);
virtual ~KeyframeEffect() override = default;
@ -130,6 +133,8 @@ private:
Vector<JS::Object*> m_keyframe_objects {};
RefPtr<KeyFrameSet const> m_key_frame_set {};
Optional<CSS::AnimationPlayState> m_last_css_animation_play_state;
};
}