From e52c09ad4c682c524ea9a3fdbdd11d9f40901dc3 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sat, 26 Apr 2025 07:44:31 -0400 Subject: [PATCH] LibWeb: Avoid copying a URL needlessly during subframe navigation Noticed a clangd warning for this while looking at a subframe site isolation issue. --- Libraries/LibWeb/HTML/NavigableContainer.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Libraries/LibWeb/HTML/NavigableContainer.cpp b/Libraries/LibWeb/HTML/NavigableContainer.cpp index 9aa8c8a3fa4..2d09af66275 100644 --- a/Libraries/LibWeb/HTML/NavigableContainer.cpp +++ b/Libraries/LibWeb/HTML/NavigableContainer.cpp @@ -256,11 +256,14 @@ void NavigableContainer::navigate_an_iframe_or_frame(URL::URL url, ReferrerPolic Variant document_resource = Empty {}; if (srcdoc_string.has_value()) document_resource = srcdoc_string.value(); - MUST(m_content_navigable->navigate({ .url = url, + + MUST(m_content_navigable->navigate({ + .url = move(url), .source_document = document(), .document_resource = document_resource, .history_handling = history_handling, - .referrer_policy = referrer_policy })); + .referrer_policy = referrer_policy, + })); } // https://html.spec.whatwg.org/multipage/document-sequences.html#destroy-a-child-navigable