mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-04 23:30:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

WebDriver: Correctly report the client's readiness state

Browse source
This commit is contained in:
Timothy Flynn 2025-02-17 09:10:30 -05:00 • committed by Tim Flynn
commit e53df7e6c9
Notes: github-actions[bot] 2025-02-17 16:15:34 +00:00
1 changed files with 16 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Services/WebDriver/Client.cpp
View file

@ -106,21 +106,32 @@ Web::WebDriver::Response Client::delete_session(Web::WebDriver::Parameters param
return JsonValue {};
}
// https://w3c.github.io/webdriver/#dfn-readiness-state
static bool readiness_state()
{
// The readiness state of a remote end indicates whether it is free to accept new connections. It must be false if
// the implementation is an endpoint node and the list of active HTTP sessions is not empty, or otherwise if the
// remote end is known to be in a state in which attempting to create new sessions would fail. In all other cases it
// must be true.
return Session::session_count(Web::WebDriver::SessionFlags::Http) == 0;
}
// 8.3 Status, https://w3c.github.io/webdriver/#dfn-status
// GET /status
Web::WebDriver::Response Client::get_status(Web::WebDriver::Parameters, JsonValue)
{
dbgln_if(WEBDRIVER_DEBUG, "Handling GET /status");
auto readiness_state = WebDriver::readiness_state();
// 1. Let body be a new JSON Object with the following properties:
// "ready"
// The remote end’s readiness state.
// The remote end's readiness state.
// "message"
// An implementation-defined string explaining the remote end’s readiness state.
// FIXME: Report if we are somehow not ready.
// An implementation-defined string explaining the remote end's readiness state.
JsonObject body;
body.set("ready", true);
body.set("message", "Ready to start some sessions!");
body.set("ready", readiness_state);
body.set("message", ByteString::formatted("{} to accept a new session", readiness_state ? "Ready"sv : "Not ready"sv));
// 2. Return success with data body.
return JsonValue { body };