mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 20:29:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

AK+Everywhere: Store JSON object keys as String

Browse source
This commit is contained in:
Timothy Flynn 2025-02-17 12:18:27 -05:00 • committed by Tim Flynn
commit e591636419
Notes: github-actions[bot] 2025-02-21 00:29:28 +00:00
23 changed files with 119 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

10
AK/JsonObject.h
View file

@ -15,12 +15,13 @@
#include <AK/JsonArray.h>
#include <AK/JsonObjectSerializer.h>
#include <AK/JsonValue.h>
#include <AK/String.h>
namespace AK {
class JsonObject {
template<typename Callback>
using CallbackErrorType = decltype(declval<Callback>()(declval<ByteString const&>(), declval<JsonValue const&>()).release_error());
using CallbackErrorType = decltype(declval<Callback>()(declval<String const&>(), declval<JsonValue const&>()).release_error());
public:
JsonObject();
@ -86,7 +87,8 @@ public:
Optional<double> get_double_with_precision_loss(StringView key) const;
Optional<float> get_float_with_precision_loss(StringView key) const;
void set(ByteString const& key, JsonValue value);
void set(String key, JsonValue value);
void set(StringView key, JsonValue value);
template<typename Callback>
void for_each_member(Callback callback) const
@ -95,7 +97,7 @@ public:
callback(member.key, member.value);
}
template<FallibleFunction<ByteString const&, JsonValue const&> Callback>
template<FallibleFunction<String const&, JsonValue const&> Callback>
ErrorOr<void, CallbackErrorType<Callback>> try_for_each_member(Callback&& callback) const
{
for (auto const& member : m_members)
@ -114,7 +116,7 @@ public:
[[nodiscard]] ByteString to_byte_string() const;
private:
OrderedHashMap<ByteString, JsonValue> m_members;
OrderedHashMap<String, JsonValue> m_members;
};
template<typename Builder>