mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 17:49:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Implement grid-template function fit-content()

Browse source
This commit is contained in:
Edwin Hoksberg 2024-07-22 22:49:52 +02:00 • committed by Andreas Kling
commit e5deaa1c07
Notes: github-actions[bot] 2024-07-25 11:13:31 +00:00
10 changed files with 211 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Tests/LibWeb/Layout/expected/grid/fit-content-1.txt Normal file
View file

@ -0,0 +1,21 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x17 children: not-inline
Box <div.container> at (8,8) content-size 784x17 [GFC] children: not-inline
BlockContainer <div.one> at (8,8) content-size 6.34375x17 [BFC] children: inline
frag 0 from TextNode start: 0, length: 1, rect: [8,8 6.34375x17] baseline: 13.296875
"1"
TextNode <#text>
BlockContainer <div.two> at (14.34375,8) content-size 8.8125x17 [BFC] children: inline
frag 0 from TextNode start: 0, length: 1, rect: [14.34375,8 8.8125x17] baseline: 13.296875
"2"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x17]
PaintableBox (Box<DIV>.container) [8,8 784x17]
PaintableWithLines (BlockContainer<DIV>.one) [8,8 6.34375x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.two) [14.34375,8 8.8125x17]
TextPaintable (TextNode<#text>)

46
Tests/LibWeb/Layout/expected/grid/fit-content-2.txt Normal file
View file

@ -0,0 +1,46 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x200 children: not-inline
Box <div#container> at (18,18) content-size 764x180 [GFC] children: not-inline
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div> at (23,23) content-size 156.984375x170 [BFC] children: inline
frag 0 from TextNode start: 0, length: 15, rect: [23,23 126.109375x17] baseline: 13.296875
"Item as wide as"
frag 1 from TextNode start: 16, length: 12, rect: [23,40 98.125x17] baseline: 13.296875
"the content."
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div> at (194.984375,23) content-size 290x170 [BFC] children: inline
frag 0 from TextNode start: 1, length: 34, rect: [194.984375,23 278.625x17] baseline: 13.296875
"Item with more text in it. Because"
frag 1 from TextNode start: 36, length: 33, rect: [194.984375,40 274.53125x17] baseline: 13.296875
"the contents of it are wider than"
frag 2 from TextNode start: 70, length: 35, rect: [194.984375,57 289.90625x17] baseline: 13.296875
"the maximum width, it is clamped at"
frag 3 from TextNode start: 106, length: 11, rect: [194.984375,74 86.609375x17] baseline: 13.296875
"300 pixels."
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div> at (499.984375,23) content-size 277.015625x170 [BFC] children: inline
frag 0 from TextNode start: 0, length: 13, rect: [499.984375,23 102.53125x17] baseline: 13.296875
"Flexible item"
TextNode <#text>
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,208) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x200]
PaintableBox (Box<DIV>#container) [8,8 784x200]
PaintableWithLines (BlockContainer<DIV>) [18,18 166.984375x180]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [189.984375,18 300x180]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [494.984375,18 287.015625x180]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,208 784x0]

15
Tests/LibWeb/Layout/input/grid/fit-content-1.html Normal file
View file

@ -0,0 +1,15 @@
<style>
.container {
display: grid;
background-color: lightsalmon;
grid-template-columns: fit-content(150px) fit-content(150px);
}
.one {
background-color: lightblue;
}
.two {
background-color: yellowgreen;
}
</style><div class="container"><div class="one">1</div><div class="two">2</div></div>

25
Tests/LibWeb/Layout/input/grid/fit-content-2.html Normal file
View file

@ -0,0 +1,25 @@
<style>
#container {
display: grid;
grid-template-columns: fit-content(300px) fit-content(300px) 1fr;
grid-gap: 5px;
box-sizing: border-box;
height: 200px;
width: 100%;
background-color: #8cffa0;
padding: 10px;
}
#container > div {
background-color: #8ca0ff;
padding: 5px;
}
</style><div id="container">
<div>Item as wide as the content.</div>
<div>
Item with more text in it. Because the contents of it are wider than the
maximum width, it is clamped at 300 pixels.
</div>
<div>Flexible item</div>
</div>

35
Userland/Libraries/LibWeb/CSS/GridTrackSize.cpp
View file

@ -10,6 +10,13 @@
namespace Web::CSS { namespace Web::CSS {
GridSize::GridSize(Type type, LengthPercentage length_percentage)
: m_value(move(length_percentage))
{
VERIFY(type == Type::FitContent);
m_type = type;
}
GridSize::GridSize(LengthPercentage length_percentage) GridSize::GridSize(LengthPercentage length_percentage)
: m_type(Type::LengthPercentage) : m_type(Type::LengthPercentage)
, m_value(move(length_percentage)) , m_value(move(length_percentage))
@ -63,7 +70,7 @@ bool GridSize::is_fixed(Layout::AvailableSize const& available_size) const
bool GridSize::is_intrinsic(Layout::AvailableSize const& available_size) const bool GridSize::is_intrinsic(Layout::AvailableSize const& available_size) const
{ {
return is_auto(available_size) || is_max_content() || is_min_content(); return is_auto(available_size) || is_max_content() || is_min_content() || is_fit_content();
} }
GridSize GridSize::make_auto() GridSize GridSize::make_auto()
@ -73,7 +80,7 @@ GridSize GridSize::make_auto()
Size GridSize::css_size() const Size GridSize::css_size() const
{ {
VERIFY(m_type == Type::LengthPercentage); VERIFY(m_type == Type::LengthPercentage || m_type == Type::FitContent);
auto& length_percentage = m_value.get<LengthPercentage>(); auto& length_percentage = m_value.get<LengthPercentage>();
if (length_percentage.is_auto()) if (length_percentage.is_auto())
return CSS::Size::make_auto(); return CSS::Size::make_auto();
@ -88,6 +95,7 @@ String GridSize::to_string() const
{ {
switch (m_type) { switch (m_type) {
case Type::LengthPercentage: case Type::LengthPercentage:
case Type::FitContent:
return m_value.get<LengthPercentage>().to_string(); return m_value.get<LengthPercentage>().to_string();
case Type::FlexibleLength: case Type::FlexibleLength:
return m_value.get<Flex>().to_string(); return m_value.get<Flex>().to_string();
@ -116,6 +124,21 @@ String GridMinMax::to_string() const
return MUST(builder.to_string()); return MUST(builder.to_string());
} }
GridFitContent::GridFitContent(GridSize max_grid_size)
: m_max_grid_size(max_grid_size)
{
}
GridFitContent::GridFitContent()
: m_max_grid_size(GridSize::make_auto())
{
}
String GridFitContent::to_string() const
{
return MUST(String::formatted("fit-content({})", m_max_grid_size.to_string()));
}
GridRepeat::GridRepeat(GridTrackSizeList grid_track_size_list, int repeat_count) GridRepeat::GridRepeat(GridTrackSizeList grid_track_size_list, int repeat_count)
: m_type(Type::Default) : m_type(Type::Default)
, m_grid_track_size_list(grid_track_size_list) , m_grid_track_size_list(grid_track_size_list)
@ -156,6 +179,12 @@ String GridRepeat::to_string() const
return MUST(builder.to_string()); return MUST(builder.to_string());
} }
ExplicitGridTrack::ExplicitGridTrack(CSS::GridFitContent grid_fit_content)
: m_type(Type::FitContent)
, m_grid_fit_content(grid_fit_content)
{
}
ExplicitGridTrack::ExplicitGridTrack(CSS::GridMinMax grid_minmax) ExplicitGridTrack::ExplicitGridTrack(CSS::GridMinMax grid_minmax)
: m_type(Type::MinMax) : m_type(Type::MinMax)
, m_grid_minmax(grid_minmax) , m_grid_minmax(grid_minmax)
@ -177,6 +206,8 @@ ExplicitGridTrack::ExplicitGridTrack(CSS::GridSize grid_size)
String ExplicitGridTrack::to_string() const String ExplicitGridTrack::to_string() const
{ {
switch (m_type) { switch (m_type) {
case Type::FitContent:
return m_grid_fit_content.to_string();
case Type::MinMax: case Type::MinMax:
return m_grid_minmax.to_string(); return m_grid_minmax.to_string();
case Type::Repeat: case Type::Repeat:

33
Userland/Libraries/LibWeb/CSS/GridTrackSize.h
View file

@ -17,10 +17,12 @@ public:
enum class Type { enum class Type {
LengthPercentage, LengthPercentage,
FlexibleLength, FlexibleLength,
FitContent,
MaxContent, MaxContent,
MinContent, MinContent,
}; };
GridSize(Type, LengthPercentage);
GridSize(LengthPercentage); GridSize(LengthPercentage);
GridSize(Flex); GridSize(Flex);
GridSize(Type); GridSize(Type);
@ -34,6 +36,7 @@ public:
bool is_auto(Layout::AvailableSize const&) const; bool is_auto(Layout::AvailableSize const&) const;
bool is_fixed(Layout::AvailableSize const&) const; bool is_fixed(Layout::AvailableSize const&) const;
bool is_flexible_length() const { return m_type == Type::FlexibleLength; } bool is_flexible_length() const { return m_type == Type::FlexibleLength; }
bool is_fit_content() const { return m_type == Type::FitContent; }
bool is_max_content() const { return m_type == Type::MaxContent; } bool is_max_content() const { return m_type == Type::MaxContent; }
bool is_min_content() const { return m_type == Type::MinContent; } bool is_min_content() const { return m_type == Type::MinContent; }
@ -42,7 +45,6 @@ public:
// https://www.w3.org/TR/css-grid-2/#layout-algorithm // https://www.w3.org/TR/css-grid-2/#layout-algorithm
// An intrinsic sizing function (min-content, max-content, auto, fit-content()). // An intrinsic sizing function (min-content, max-content, auto, fit-content()).
// FIXME: Add missing properties once implemented.
bool is_intrinsic(Layout::AvailableSize const&) const; bool is_intrinsic(Layout::AvailableSize const&) const;
bool is_definite() const bool is_definite() const
@ -64,6 +66,23 @@ private:
Variant<Empty, LengthPercentage, Flex> m_value; Variant<Empty, LengthPercentage, Flex> m_value;
}; };
class GridFitContent {
public:
GridFitContent(GridSize);
GridFitContent();
GridSize max_grid_size() const& { return m_max_grid_size; }
String to_string() const;
bool operator==(GridFitContent const& other) const
{
return m_max_grid_size == other.m_max_grid_size;
}
private:
GridSize m_max_grid_size;
};
class GridMinMax { class GridMinMax {
public: public:
GridMinMax(CSS::GridSize min_grid_size, CSS::GridSize max_grid_size); GridMinMax(CSS::GridSize min_grid_size, CSS::GridSize max_grid_size);
@ -149,14 +168,23 @@ private:
class ExplicitGridTrack { class ExplicitGridTrack {
public: public:
enum class Type { enum class Type {
FitContent,
MinMax, MinMax,
Repeat, Repeat,
Default, Default,
}; };
ExplicitGridTrack(CSS::GridFitContent);
ExplicitGridTrack(CSS::GridRepeat); ExplicitGridTrack(CSS::GridRepeat);
ExplicitGridTrack(CSS::GridMinMax); ExplicitGridTrack(CSS::GridMinMax);
ExplicitGridTrack(CSS::GridSize); ExplicitGridTrack(CSS::GridSize);
bool is_fit_content() const { return m_type == Type::FitContent; }
GridFitContent fit_content() const
{
VERIFY(is_fit_content());
return m_grid_fit_content;
}
bool is_repeat() const { return m_type == Type::Repeat; } bool is_repeat() const { return m_type == Type::Repeat; }
GridRepeat repeat() const GridRepeat repeat() const
{ {
@ -183,6 +211,8 @@ public:
String to_string() const; String to_string() const;
bool operator==(ExplicitGridTrack const& other) const bool operator==(ExplicitGridTrack const& other) const
{ {
if (is_fit_content() && other.is_fit_content())
return m_grid_fit_content == other.fit_content();
if (is_repeat() && other.is_repeat()) if (is_repeat() && other.is_repeat())
return m_grid_repeat == other.repeat(); return m_grid_repeat == other.repeat();
if (is_minmax() && other.is_minmax()) if (is_minmax() && other.is_minmax())
@ -194,6 +224,7 @@ public:
private: private:
Type m_type; Type m_type;
GridFitContent m_grid_fit_content;
GridRepeat m_grid_repeat; GridRepeat m_grid_repeat;
GridMinMax m_grid_minmax; GridMinMax m_grid_minmax;
GridSize m_grid_size; GridSize m_grid_size;

20
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -5910,6 +5910,21 @@ Optional<CSS::GridSize> Parser::parse_grid_size(ComponentValue const& component_
return {}; return {};
} }
Optional<CSS::GridFitContent> Parser::parse_fit_content(Vector<ComponentValue> const& component_values)
{
// https://www.w3.org/TR/css-grid-2/#valdef-grid-template-columns-fit-content
// 'fit-content( <length-percentage> )'
// Represents the formula max(minimum, min(limit, max-content)), where minimum represents an auto minimum (which is often, but not always,
// equal to a min-content minimum), and limit is the track sizing function passed as an argument to fit-content().
// This is essentially calculated as the smaller of minmax(auto, max-content) and minmax(auto, limit).
auto function_tokens = TokenStream(component_values);
function_tokens.skip_whitespace();
auto maybe_length_percentage = parse_length_percentage(function_tokens);
if (maybe_length_percentage.has_value())
return CSS::GridFitContent(CSS::GridSize(CSS::GridSize::Type::FitContent, maybe_length_percentage.value()));
return {};
}
Optional<CSS::GridMinMax> Parser::parse_min_max(Vector<ComponentValue> const& component_values) Optional<CSS::GridMinMax> Parser::parse_min_max(Vector<ComponentValue> const& component_values)
{ {
// https://www.w3.org/TR/css-grid-2/#valdef-grid-template-columns-minmax // https://www.w3.org/TR/css-grid-2/#valdef-grid-template-columns-minmax
@ -6067,6 +6082,11 @@ Optional<CSS::ExplicitGridTrack> Parser::parse_track_sizing_function(ComponentVa
return CSS::ExplicitGridTrack(maybe_min_max_value.value()); return CSS::ExplicitGridTrack(maybe_min_max_value.value());
else else
return {}; return {};
} else if (function_token.name().equals_ignoring_ascii_case("fit-content"sv)) {
auto maybe_fit_content_value = parse_fit_content(function_token.values());
if (maybe_fit_content_value.has_value())
return CSS::ExplicitGridTrack(maybe_fit_content_value.value());
return {};
} else if (auto maybe_calculated = parse_calculated_value(token)) { } else if (auto maybe_calculated = parse_calculated_value(token)) {
return CSS::ExplicitGridTrack(GridSize(LengthPercentage(maybe_calculated.release_nonnull()))); return CSS::ExplicitGridTrack(GridSize(LengthPercentage(maybe_calculated.release_nonnull())));
} }

1
Userland/Libraries/LibWeb/CSS/Parser/Parser.h
View file

@ -250,6 +250,7 @@ private:
Optional<Gfx::UnicodeRange> parse_unicode_range(StringView); Optional<Gfx::UnicodeRange> parse_unicode_range(StringView);
Vector<Gfx::UnicodeRange> parse_unicode_ranges(TokenStream<ComponentValue>&); Vector<Gfx::UnicodeRange> parse_unicode_ranges(TokenStream<ComponentValue>&);
Optional<GridSize> parse_grid_size(ComponentValue const&); Optional<GridSize> parse_grid_size(ComponentValue const&);
Optional<GridFitContent> parse_fit_content(Vector<ComponentValue> const&);
Optional<GridMinMax> parse_min_max(Vector<ComponentValue> const&); Optional<GridMinMax> parse_min_max(Vector<ComponentValue> const&);
Optional<GridRepeat> parse_repeat(Vector<ComponentValue> const&); Optional<GridRepeat> parse_repeat(Vector<ComponentValue> const&);
Optional<ExplicitGridTrack> parse_track_sizing_function(ComponentValue const&); Optional<ExplicitGridTrack> parse_track_sizing_function(ComponentValue const&);

1
Userland/Libraries/LibWeb/Forward.h
View file

@ -137,6 +137,7 @@ class FrequencyOrCalculated;
class FrequencyPercentage; class FrequencyPercentage;
class FrequencyStyleValue; class FrequencyStyleValue;
class GridAutoFlowStyleValue; class GridAutoFlowStyleValue;
class GridFitContent;
class GridMinMax; class GridMinMax;
class GridRepeat; class GridRepeat;
class GridSize; class GridSize;

21
Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp
View file

@ -17,6 +17,13 @@ GridFormattingContext::GridTrack GridFormattingContext::GridTrack::create_from_d
// NOTE: repeat() is expected to be expanded beforehand. // NOTE: repeat() is expected to be expanded beforehand.
VERIFY(!definition.is_repeat()); VERIFY(!definition.is_repeat());
if (definition.is_fit_content()) {
return GridTrack {
.min_track_sizing_function = CSS::GridSize::make_auto(),
.max_track_sizing_function = definition.fit_content().max_grid_size(),
};
}
if (definition.is_minmax()) { if (definition.is_minmax()) {
return GridTrack { return GridTrack {
.min_track_sizing_function = definition.minmax().min_grid_size(), .min_track_sizing_function = definition.minmax().min_grid_size(),
@ -422,6 +429,7 @@ void GridFormattingContext::initialize_grid_tracks_from_definition(GridDimension
for (auto _ = 0; _ < repeat_count; _++) { for (auto _ = 0; _ < repeat_count; _++) {
switch (track_definition.type()) { switch (track_definition.type()) {
case CSS::ExplicitGridTrack::Type::Default: case CSS::ExplicitGridTrack::Type::Default:
case CSS::ExplicitGridTrack::Type::FitContent:
case CSS::ExplicitGridTrack::Type::MinMax: case CSS::ExplicitGridTrack::Type::MinMax:
tracks.append(GridTrack::create_from_definition(track_definition)); tracks.append(GridTrack::create_from_definition(track_definition));
break; break;
@ -852,13 +860,18 @@ void GridFormattingContext::increase_sizes_to_accommodate_spanning_items_crossin
// 6. For max-content maximums: Lastly continue to increase the growth limit of tracks with a max track // 6. For max-content maximums: Lastly continue to increase the growth limit of tracks with a max track
// sizing function of max-content by distributing extra space as needed to account for these items' max- // sizing function of max-content by distributing extra space as needed to account for these items' max-
// content contributions. // content contributions. However, limit the growth of any fit-content() tracks by their fit-content() argument.
auto item_max_content_contribution = calculate_max_content_contribution(item, dimension); auto item_max_content_contribution = calculate_max_content_contribution(item, dimension);
distribute_extra_space_across_spanned_tracks_growth_limit(item_max_content_contribution, spanned_tracks, [&](GridTrack const& track) { distribute_extra_space_across_spanned_tracks_growth_limit(item_max_content_contribution, spanned_tracks, [&](GridTrack const& track) {
return track.max_track_sizing_function.is_max_content() || track.max_track_sizing_function.is_auto(available_size); return track.max_track_sizing_function.is_max_content() || track.max_track_sizing_function.is_auto(available_size) || track.max_track_sizing_function.is_fit_content();
}); });
for (auto& track : spanned_tracks) { for (auto& track : spanned_tracks) {
if (!track.growth_limit.has_value()) { if (track.max_track_sizing_function.is_fit_content()) {
track.growth_limit = css_clamp(
track.planned_increase,
track.base_size,
track.max_track_sizing_function.css_size().to_px(grid_container(), available_size.to_px_or_zero()));
} else if (!track.growth_limit.has_value()) {
// If the affected size is an infinite growth limit, set it to the track’s base size plus the planned increase. // If the affected size is an infinite growth limit, set it to the track’s base size plus the planned increase.
track.growth_limit = track.base_size + track.planned_increase; track.growth_limit = track.base_size + track.planned_increase;
} else { } else {
@ -2039,7 +2052,7 @@ void GridFormattingContext::init_grid_lines(GridDimension dimension)
line_names.extend(item.get<CSS::GridLineNames>().names); line_names.extend(item.get<CSS::GridLineNames>().names);
} else if (item.has<CSS::ExplicitGridTrack>()) { } else if (item.has<CSS::ExplicitGridTrack>()) {
auto const& explicit_track = item.get<CSS::ExplicitGridTrack>(); auto const& explicit_track = item.get<CSS::ExplicitGridTrack>();
if (explicit_track.is_default() || explicit_track.is_minmax()) { if (explicit_track.is_default() || explicit_track.is_minmax() || explicit_track.is_fit_content()) {
lines.append({ .names = line_names }); lines.append({ .names = line_names });
line_names.clear(); line_names.clear();
} else if (explicit_track.is_repeat()) { } else if (explicit_track.is_repeat()) {