mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-12 19:19:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Set blur filter radius to 0px if omitted

Browse source
This commit is contained in:
Tim Ledbetter 2025-04-04 12:05:07 +01:00 • committed by Sam Atkins
commit e5f21b2f9c
Notes: github-actions[bot] 2025-04-04 16:13:53 +00:00
3 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/CSS/StyleValues/FilterValueListStyleValue.cpp
View file

@ -15,11 +15,7 @@ namespace Web::CSS {
float FilterOperation::Blur::resolved_radius(Layout::Node const& node) const
{
if (radius.has_value())
return radius->resolved({ .length_resolution_context = Length::ResolutionContext::for_layout_node(node) })->to_px(node).to_float();
// Default value when omitted is 0px.
return 0;
return radius.resolved({ .length_resolution_context = Length::ResolutionContext::for_layout_node(node) })->to_px(node).to_float();
}
float FilterOperation::HueRotate::angle_degrees(Layout::Node const& node) const
@ -56,9 +52,7 @@ String FilterValueListStyleValue::to_string(SerializationMode) const
builder.append(' ');
filter_function.visit(
[&](FilterOperation::Blur const& blur) {
builder.append("blur("sv);
if (blur.radius.has_value())
builder.append(blur.radius->to_string());
builder.appendff("blur({}"sv, blur.radius.to_string());
},
[&](FilterOperation::DropShadow const& drop_shadow) {
builder.appendff("drop-shadow("sv);

2
Libraries/LibWeb/CSS/StyleValues/FilterValueListStyleValue.h
View file

@ -21,7 +21,7 @@ namespace Web::CSS {
namespace FilterOperation {
struct Blur {
Optional<LengthOrCalculated> radius;
LengthOrCalculated radius { Length::make_px(0) };
float resolved_radius(Layout::Node const&) const;
bool operator==(Blur const&) const = default;
};