mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-05 10:42:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibHTTP+RequestServer: Add HTTP::HeaderMap and use for response headers

Browse source 
Instead of using a HashMap<ByteString, ByteString, CaseInsensitive...>
everywhere, we now encapsulate this in a class.

Even better, the new class also allows keeping track of multiple headers
with the same name! This will make it possible for HTTP responses to
actually retain all their headers on the perilous journey from
RequestServer to LibWeb.
This commit is contained in:
Andreas Kling 2024-06-09 11:28:37 +02:00 • committed by Andreas Kling
parent c096608dd9
commit e636851481
Notes: sideshowbarker 2024-07-17 06:33:00 +09:00
21 changed files with 159 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -183,13 +183,15 @@ void HTMLObjectElement::resource_did_load()
// 4. Run the appropriate set of steps from the following list:
// * If the resource has associated Content-Type metadata
if (auto it = resource()->response_headers().find("Content-Type"sv); it != resource()->response_headers().end()) {
if (auto maybe_content_type = resource()->response_headers().get("Content-Type"sv); maybe_content_type.has_value()) {
auto& content_type = maybe_content_type.value();
// 1. Let binary be false.
bool binary = false;
// 2. If the type specified in the resource's Content-Type metadata is "text/plain", and the result of applying the rules for distinguishing if a resource is text or binary to the resource is that the resource is not text/plain, then set binary to true.
if (it->value == "text/plain"sv) {
auto supplied_type = MimeSniff::MimeType::parse(it->value).release_value_but_fixme_should_propagate_errors();
if (content_type == "text/plain"sv) {
auto supplied_type = MimeSniff::MimeType::parse(content_type).release_value_but_fixme_should_propagate_errors();
auto computed_type = MimeSniff::Resource::sniff(resource()->encoded_data(), MimeSniff::SniffingConfiguration {
.sniffing_context = MimeSniff::SniffingContext::TextOrBinary,
.supplied_type = move(supplied_type),
@ -200,12 +202,12 @@ void HTMLObjectElement::resource_did_load()
}
// 3. If the type specified in the resource's Content-Type metadata is "application/octet-stream", then set binary to true.
if (it->value == "application/octet-stream"sv)
if (content_type == "application/octet-stream"sv)
binary = true;
// 4. If binary is false, then let the resource type be the type specified in the resource's Content-Type metadata, and jump to the step below labeled handler.
if (!binary)
return run_object_representation_handler_steps(it->value);
return run_object_representation_handler_steps(content_type);
// 5. If there is a type attribute present on the object element, and its value is not application/octet-stream, then run the following steps:
if (auto type = this->type(); !type.is_empty() && (type != "application/octet-stream"sv)) {