mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 08:39:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use plain Vector for HTMLMediaElement::m_pending_play_promises

Browse source 
These are now covered by visit_edges() instead of being strong GC roots.
This commit is contained in:
Andreas Kling 2024-04-01 10:39:25 +02:00
commit e66a4668f9
Notes: sideshowbarker 2024-07-17 06:33:00 +09:00
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -44,7 +44,6 @@ namespace Web::HTML {
HTMLMediaElement::HTMLMediaElement(DOM::Document& document, DOM::QualifiedName qualified_name) HTMLMediaElement::HTMLMediaElement(DOM::Document& document, DOM::QualifiedName qualified_name)
: HTMLElement(document, move(qualified_name)) : HTMLElement(document, move(qualified_name))
, m_pending_play_promises(heap())
{ {
} }
@ -91,6 +90,8 @@ void HTMLMediaElement::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_document_observer); visitor.visit(m_document_observer);
visitor.visit(m_source_element_selector); visitor.visit(m_source_element_selector);
visitor.visit(m_fetch_controller); visitor.visit(m_fetch_controller);
for (auto& promise : m_pending_play_promises)
visitor.visit(promise);
} }
void HTMLMediaElement::attribute_changed(FlyString const& name, Optional<String> const& value) void HTMLMediaElement::attribute_changed(FlyString const& name, Optional<String> const& value)
@ -1847,7 +1848,8 @@ JS::MarkedVector<JS::NonnullGCPtr<WebIDL::Promise>> HTMLMediaElement::take_pendi
// 1. Let promises be an empty list of promises. // 1. Let promises be an empty list of promises.
// 2. Copy the media element's list of pending play promises to promises. // 2. Copy the media element's list of pending play promises to promises.
// 3. Clear the media element's list of pending play promises. // 3. Clear the media element's list of pending play promises.
auto promises = move(m_pending_play_promises); JS::MarkedVector<JS::NonnullGCPtr<WebIDL::Promise>> promises(heap());
promises.extend(move(m_pending_play_promises));
// 4. Return promises. // 4. Return promises.
return promises; return promises;

2
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.h
View file

@ -242,7 +242,7 @@ private:
double m_duration { NAN }; double m_duration { NAN };
// https://html.spec.whatwg.org/multipage/media.html#list-of-pending-play-promises // https://html.spec.whatwg.org/multipage/media.html#list-of-pending-play-promises
JS::MarkedVector<JS::NonnullGCPtr<WebIDL::Promise>> m_pending_play_promises; Vector<JS::NonnullGCPtr<WebIDL::Promise>> m_pending_play_promises;
// https://html.spec.whatwg.org/multipage/media.html#dom-media-paused // https://html.spec.whatwg.org/multipage/media.html#dom-media-paused
bool m_paused { true }; bool m_paused { true };