From e6c96ce57e3753f12c84057f2e45e7813d1666fe Mon Sep 17 00:00:00 2001
From: Timothy Flynn <trflynn89@pm.me>
Date: Tue, 3 Dec 2024 11:36:08 -0500
Subject: [PATCH] LibCrypto: Convert BigFraction stringification to String

---
 Libraries/LibCrypto/BigFraction/BigFraction.cpp | 4 ++--
 Libraries/LibCrypto/BigFraction/BigFraction.h   | 2 +-
 Tests/LibCrypto/TestBigFraction.cpp             | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Libraries/LibCrypto/BigFraction/BigFraction.cpp b/Libraries/LibCrypto/BigFraction/BigFraction.cpp
index 0c42059c912..dea8204942e 100644
--- a/Libraries/LibCrypto/BigFraction/BigFraction.cpp
+++ b/Libraries/LibCrypto/BigFraction/BigFraction.cpp
@@ -185,7 +185,7 @@ void BigFraction::reduce()
     m_denominator = denominator_divide.quotient;
 }
 
-ByteString BigFraction::to_byte_string(unsigned rounding_threshold) const
+String BigFraction::to_string(unsigned rounding_threshold) const
 {
     StringBuilder builder;
     if (m_numerator.is_negative() && m_numerator != "0"_bigint)
@@ -240,7 +240,7 @@ ByteString BigFraction::to_byte_string(unsigned rounding_threshold) const
             builder.append(fractional_value);
     }
 
-    return builder.to_byte_string();
+    return MUST(builder.to_string());
 }
 
 BigFraction BigFraction::sqrt() const
diff --git a/Libraries/LibCrypto/BigFraction/BigFraction.h b/Libraries/LibCrypto/BigFraction/BigFraction.h
index 6fdf647bb0a..d0cc8a6ad9f 100644
--- a/Libraries/LibCrypto/BigFraction/BigFraction.h
+++ b/Libraries/LibCrypto/BigFraction/BigFraction.h
@@ -55,7 +55,7 @@ public:
     //      - m_denominator = 10000
     BigFraction rounded(unsigned rounding_threshold) const;
 
-    ByteString to_byte_string(unsigned rounding_threshold) const;
+    String to_string(unsigned rounding_threshold) const;
     double to_double() const;
 
     Crypto::SignedBigInteger const& numerator() const& { return m_numerator; }
diff --git a/Tests/LibCrypto/TestBigFraction.cpp b/Tests/LibCrypto/TestBigFraction.cpp
index 8fbf311867a..b0ce75fabe2 100644
--- a/Tests/LibCrypto/TestBigFraction.cpp
+++ b/Tests/LibCrypto/TestBigFraction.cpp
@@ -23,6 +23,6 @@ TEST_CASE(roundtrip_from_string)
     for (auto valid_number_string : valid_number_strings) {
         auto result = TRY_OR_FAIL(Crypto::BigFraction::from_string(valid_number_string));
         auto precision = valid_number_string.length() - valid_number_string.find('.').value();
-        EXPECT_EQ(result.to_byte_string(precision), valid_number_string);
+        EXPECT_EQ(result.to_string(precision), valid_number_string);
     }
 }