mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 16:49:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Report exceptions that occur during resize observer callback

Browse source
This commit is contained in:
Tim Ledbetter 2024-12-05 10:19:28 +00:00 • committed by Tim Ledbetter
commit e74d8a6003
Notes: github-actions[bot] 2024-12-19 15:26:08 +00:00
3 changed files with 37 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/ResizeObserver/ResizeObserver.cpp
View file

@ -109,9 +109,7 @@ void ResizeObserver::invoke_callback(ReadonlySpan<GC::Ref<ResizeObserverEntry>>
MUST(wrapped_records->create_data_property(property_index, record.ptr()));
}
auto result = WebIDL::invoke_callback(callback, JS::js_undefined(), wrapped_records);
if (result.is_abrupt())
HTML::report_exception(result, realm);
(void)WebIDL::invoke_callback(callback, JS::js_undefined(), WebIDL::ExceptionBehavior::Report, wrapped_records);
}
}

6
Tests/LibWeb/Text/expected/wpt-import/resize-observer/callback-cross-realm-report-exception.txt Normal file
View file

@ -0,0 +1,6 @@
Harness status: OK
Found 1 tests
1 Pass
Pass ResizeObserver reports the exception from its callback in the callback's global object

30
Tests/LibWeb/Text/input/wpt-import/resize-observer/callback-cross-realm-report-exception.html Normal file
View file

@ -0,0 +1,30 @@
<!doctype html>
<meta charset=utf-8>
<title>ResizeObserver reports the exception from its callback in the callback's global object</title>
<script src=../resources/testharness.js></script>
<script src=../resources/testharnessreport.js></script>
<iframe srcdoc='<div style="height: 100px;">foo</div>'></iframe>
<iframe></iframe>
<iframe></iframe>
<script>
setup({ allow_uncaught_exception: true });
const onerrorCalls = [];
window.onerror = () => { onerrorCalls.push("top"); };
frames[0].onerror = () => { onerrorCalls.push("frame0"); };
frames[1].onerror = () => { onerrorCalls.push("frame1"); };
frames[2].onerror = () => { onerrorCalls.push("frame2"); };
async_test(t => {
window.onload = t.step_func(() => {
const target = frames[0].document.querySelector("div");
const io = new frames[0].ResizeObserver(new frames[1].Function(`throw new parent.frames[2].Error("PASS");`));
io.observe(target);
t.step_timeout(() => {
assert_array_equals(onerrorCalls, ["frame1"]);
t.done();
}, 25);
});
});
</script>