Userland: Compare event MIME type list with a StringView

The following commit will port MIME types to String. Traits<String> - used in Vector::contains_slow - can't compare String type with char*, so we need to use StringView instead.
Author: https://github.com/krkk Commit: https://github.com/SerenityOS/serenity/commit/e75d694974 Pull-request: https://github.com/SerenityOS/serenity/pull/21179 Reviewed-by: https://github.com/AtkinsSJ ✅
2025-04-22 04:25:13 +00:00 · 2023-09-21 19:02:52 +02:00 · 2023-09-21 19:02:52 +02:00 · e75d694974 · 2024-07-17 04:09:56 +09:00
commit e75d694974
parent 2f35348104
16 changed files with 16 additions and 16 deletions
--- a/Userland/Applications/3DFileViewer/main.cpp
+++ b/Userland/Applications/3DFileViewer/main.cpp
@ -128,7 +128,7 @@ private:
 void GLContextWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Applications/FontEditor/MainWidget.cpp
+++ b/Userland/Applications/FontEditor/MainWidget.cpp
@ -987,7 +987,7 @@ void MainWidget::update_preview()
 void MainWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Applications/HexEditor/HexEditorWidget.cpp
+++ b/Userland/Applications/HexEditor/HexEditorWidget.cpp
@ -624,7 +624,7 @@ void HexEditorWidget::set_value_inspector_visible(bool visible)
 void HexEditorWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Applications/ImageViewer/ViewWidget.cpp
+++ b/Userland/Applications/ImageViewer/ViewWidget.cpp
@ -283,7 +283,7 @@ ErrorOr<void> ViewWidget::try_open_file(String const& path, Core::File& file)
 void ViewWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Applications/PixelPaint/MainWidget.cpp
+++ b/Userland/Applications/PixelPaint/MainWidget.cpp
@ -1473,7 +1473,7 @@ ImageEditor& MainWidget::create_new_editor(NonnullRefPtr<Image> image)
 void MainWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Applications/Presenter/PresenterWidget.cpp
+++ b/Userland/Applications/Presenter/PresenterWidget.cpp
@ -203,7 +203,7 @@ void PresenterWidget::second_paint_event(GUI::PaintEvent& event)
 void PresenterWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Applications/SoundPlayer/SoundPlayerWidget.cpp
+++ b/Userland/Applications/SoundPlayer/SoundPlayerWidget.cpp
@ -148,7 +148,7 @@ void SoundPlayerWidget::set_nonlinear_volume_slider(bool nonlinear)
 void SoundPlayerWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Applications/TextEditor/MainWidget.cpp
+++ b/Userland/Applications/TextEditor/MainWidget.cpp
@ -832,7 +832,7 @@ bool MainWidget::request_close()
 void MainWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Applications/ThemeEditor/MainWidget.cpp
+++ b/Userland/Applications/ThemeEditor/MainWidget.cpp
@ -678,7 +678,7 @@ ErrorOr<void> MainWidget::load_from_file(String const& filename, NonnullOwnPtr<C
 void MainWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/DevTools/GMLPlayground/MainWidget.cpp
+++ b/Userland/DevTools/GMLPlayground/MainWidget.cpp
@ -317,7 +317,7 @@ GUI::Window::CloseRequestDecision MainWidget::request_close()
 void MainWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/DevTools/HackStudio/Editor.cpp
+++ b/Userland/DevTools/HackStudio/Editor.cpp
@ -350,7 +350,7 @@ void Editor::mousedown_event(GUI::MouseEvent& event)
 void Editor::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/DevTools/SQLStudio/MainWidget.cpp
+++ b/Userland/DevTools/SQLStudio/MainWidget.cpp
@ -470,7 +470,7 @@ void MainWidget::update_editor_actions(ScriptEditor* editor)
 void MainWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Libraries/LibGUI/FileSystemModel.cpp
+++ b/Userland/Libraries/LibGUI/FileSystemModel.cpp
@ -789,7 +789,7 @@ ErrorOr<String> FileSystemModel::column_name(int column) const

 bool FileSystemModel::accepts_drag(ModelIndex const& index, Vector<DeprecatedString> const& mime_types) const
 {
-    if (!mime_types.contains_slow("text/uri-list"))
+    if (!mime_types.contains_slow("text/uri-list"sv))
        return false;

    if (!index.is_valid())
--- a/Userland/Libraries/LibGUI/PathBreadcrumbbar.cpp
+++ b/Userland/Libraries/LibGUI/PathBreadcrumbbar.cpp
@ -69,7 +69,7 @@ PathBreadcrumbbar::PathBreadcrumbbar(NonnullRefPtr<GUI::TextBox> location_text_b
    };

    m_breadcrumbbar->on_segment_drag_enter = [&](size_t, GUI::DragEvent& event) {
-        if (event.mime_types().contains_slow("text/uri-list"))
+        if (event.mime_types().contains_slow("text/uri-list"sv))
            event.accept();
    };

--- a/Userland/Libraries/LibVT/TerminalWidget.cpp
+++ b/Userland/Libraries/LibVT/TerminalWidget.cpp
@ -1164,7 +1164,7 @@ void TerminalWidget::context_menu_event(GUI::ContextMenuEvent& event)
 void TerminalWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/plain") || mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/plain"sv) || mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }

--- a/Userland/Services/Taskbar/QuickLaunchWidget.cpp
+++ b/Userland/Services/Taskbar/QuickLaunchWidget.cpp
@ -232,7 +232,7 @@ void QuickLaunchWidget::config_string_did_change(StringView domain, StringView g
 void QuickLaunchWidget::drag_enter_event(GUI::DragEvent& event)
 {
    auto const& mime_types = event.mime_types();
-    if (mime_types.contains_slow("text/uri-list"))
+    if (mime_types.contains_slow("text/uri-list"sv))
        event.accept();
 }