LibWeb/HTML: Use finalize to clean up MessagePort instances

Author: https://github.com/shannonbooth
Commit: e767029e24
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3070
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/konradekk

Libraries/LibWeb/HTML/MessagePort.cpp

@@ -47,11 +47,7 @@ MessagePort::MessagePort(JS::Realm& realm)
     all_message_ports().set(this);
 }
 
-MessagePort::~MessagePort()
+MessagePort::~MessagePort() = default;
-{
-    all_message_ports().remove(this);
-    disentangle();
-}
 
 void MessagePort::for_each_message_port(Function<void(MessagePort&)> callback)
 {
@@ -65,6 +61,13 @@ void MessagePort::initialize(JS::Realm& realm)
     WEB_SET_PROTOTYPE_FOR_INTERFACE(MessagePort);
 }
 
+void MessagePort::finalize()
+{
+    Base::finalize();
+    all_message_ports().remove(this);
+    disentangle();
+}
+
 void MessagePort::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);

Libraries/LibWeb/HTML/MessagePort.h

@@ -68,6 +68,7 @@ private:
     explicit MessagePort(JS::Realm&);
 
     virtual void initialize(JS::Realm&) override;
+    virtual void finalize() override;
     virtual void visit_edges(Cell::Visitor&) override;
 
     bool is_entangled() const;