mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-12 20:11:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Parse all as keyword in transition shorthand

Browse source 
This ensures that the parsing of the `transition` shorthand property
behaves in the same way as the `transition-property` longhand.4
This commit is contained in:
Tim Ledbetter 2025-04-28 11:37:08 +01:00 • committed by Andreas Kling
parent a3e485e2d0
commit e7ae9c8ebf
Notes: github-actions[bot] 2025-04-28 18:52:33 +00:00
8 changed files with 1076 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp
View file

@ -3756,7 +3756,18 @@ RefPtr<CSSStyleValue const> Parser::parse_transition_value(TokenStream<Component
continue;
}
if (auto transition_property = parse_custom_ident_value(tokens, { { "none"sv } })) {
if (auto token = tokens.peek_token(); token.is_ident("all"sv)) {
auto transition_keyword = parse_keyword_value(tokens);
VERIFY(transition_keyword->to_keyword() == Keyword::All);
if (transition.property_name) {
dbgln_if(CSS_PARSER_DEBUG, "Transition property has multiple property identifiers");
return {};
}
transition.property_name = transition_keyword.release_nonnull();
continue;
}
if (auto transition_property = parse_custom_ident_value(tokens, { { "all"sv, "none"sv } })) {
if (transition.property_name) {
dbgln_if(CSS_PARSER_DEBUG, "Transition property has multiple property identifiers");
return {};
@ -3774,7 +3785,7 @@ RefPtr<CSSStyleValue const> Parser::parse_transition_value(TokenStream<Component
}
if (!transition.property_name)
transition.property_name = CustomIdentStyleValue::create("all"_fly_string);
transition.property_name = CSSKeywordValue::create(Keyword::All);
if (!transition.easing)
transition.easing = EasingStyleValue::create(EasingStyleValue::CubicBezier::ease());