mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-29 20:59:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
commit e7de5cb4d2
Notes: sideshowbarker 2024-07-17 04:09:56 +09:00
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Tests/LibWeb/Layout/expected/block-and-inline/forced-break-stops-non-whitespace-sequence.txt
View file

@ -1,9 +1,9 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,16) content-size 784x19.46875 children: not-inline
BlockContainer <pre> at (9,17) content-size 782x17.46875 children: inline
line 0 width: 8, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [9,17 8x17.46875]
BlockContainer <body> at (8,16) content-size 784x19 children: not-inline
BlockContainer <pre> at (9,17) content-size 782x17 children: inline
line 0 width: 8, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [9,17 8x17]
" "
InlineNode <span>
TextNode <#text>
@ -11,7 +11,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,16 784x19.46875]
PaintableWithLines (BlockContainer<PRE>) [8,16 784x19.46875]
PaintableWithLines (BlockContainer<BODY>) [8,16 784x19]
PaintableWithLines (BlockContainer<PRE>) [8,16 784x19]
InlinePaintable (InlineNode<SPAN>)
TextPaintable (TextNode<#text>)