mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-10 01:59:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

WebContent: Parse the type hint in WebDriver's New Window endpoint

Browse source 
Although we aren't using this hint (we always create tabs), we do need
to validate the payload.
This commit is contained in:
Timothy Flynn 2024-10-21 12:39:53 -04:00 • committed by Tim Flynn
commit ebe89a3207
Notes: github-actions[bot] 2024-10-21 17:16:04 +00:00
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Services/WebContent/WebDriverConnection.cpp
View file

@ -465,7 +465,7 @@ Messages::WebDriverClient::SwitchToWindowResponse WebDriverConnection::switch_to
}
// 11.5 New Window, https://w3c.github.io/webdriver/#dfn-new-window
Messages::WebDriverClient::NewWindowResponse WebDriverConnection::new_window(JsonValue const&)
Messages::WebDriverClient::NewWindowResponse WebDriverConnection::new_window(JsonValue const& payload)
{
// 1. If the implementation does not support creating new top-level browsing contexts, return error with error code unsupported operation.
@ -475,7 +475,14 @@ Messages::WebDriverClient::NewWindowResponse WebDriverConnection::new_window(Jso
// 3. Handle any user prompts and return its value if it is an error.
TRY(handle_any_user_prompts());
// FIXME: 4. Let type hint be the result of getting the property "type" from the parameters argument.
// 4. Let type hint be the result of getting the property "type" from the parameters argument.
if (!payload.is_object())
return Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::InvalidArgument, "Payload is not a JSON object");
// FIXME: Actually use this value to decide between an OS window or tab.
auto type_hint = payload.as_object().get("type"sv);
if (type_hint.has_value() && !type_hint->is_null() && !type_hint->is_string())
return Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::InvalidArgument, "Payload property `type` is not null or a string"sv);
// 5. Create a new top-level browsing context by running the window open steps with url set to "about:blank",
// target set to the empty string, and features set to "noopener" and the user agent configured to create a new