From ec2b56891969ef97b1f8f2ef4d99df5ed93acd9e Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 18 Aug 2025 23:20:20 +0200 Subject: [PATCH] LibWeb: Add missing StyleInvalidationReason for HTMLDialogElement We were accidentally using NodeRemove instead of a unique reason. --- Libraries/LibWeb/DOM/Node.h | 1 + Libraries/LibWeb/HTML/HTMLDialogElement.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/DOM/Node.h b/Libraries/LibWeb/DOM/Node.h index af9e8730b54..a83bbef4838 100644 --- a/Libraries/LibWeb/DOM/Node.h +++ b/Libraries/LibWeb/DOM/Node.h @@ -63,6 +63,7 @@ enum class ShouldComputeRole { X(EditingInsertion) \ X(ElementAttributeChange) \ X(ElementSetShadowRoot) \ + X(HTMLDialogElementSetIsModal) \ X(HTMLHyperlinkElementHrefChange) \ X(HTMLIFrameElementGeometryChange) \ X(HTMLInputElementSetChecked) \ diff --git a/Libraries/LibWeb/HTML/HTMLDialogElement.cpp b/Libraries/LibWeb/HTML/HTMLDialogElement.cpp index 810430b0c46..d49e1704204 100644 --- a/Libraries/LibWeb/HTML/HTMLDialogElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLDialogElement.cpp @@ -467,7 +467,7 @@ void HTMLDialogElement::set_is_modal(bool is_modal) if (m_is_modal == is_modal) return; m_is_modal = is_modal; - invalidate_style(DOM::StyleInvalidationReason::NodeRemove); + invalidate_style(DOM::StyleInvalidationReason::HTMLDialogElementSetIsModal); } // https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element:is-valid-invoker-command-steps