mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-03 09:48:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/FileAPI: Implement FileReader readAsBinaryString

Browse source
This commit is contained in:
Shannon Booth 2025-01-24 00:32:30 +13:00 • committed by Sam Atkins
parent d79bb1aac2
commit eca68aad88
Notes: github-actions[bot] 2025-01-28 11:40:38 +00:00
4 changed files with 50 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/FileAPI/FileReader.cpp
View file

@ -105,8 +105,12 @@ WebIDL::ExceptionOr<FileReader::Result> FileReader::blob_package_data(JS::Realm&
// Return a new ArrayBuffer whose contents are bytes.
return JS::ArrayBuffer::create(realm, move(bytes));
case Type::BinaryString:
// FIXME: Return bytes as a binary string, in which every byte is represented by a code unit of equal value [0..255].
return WebIDL::NotSupportedError::create(realm, "BinaryString not supported yet"_string);
// Return bytes as a binary string, in which every byte is represented by a code unit of equal value [0..255].
Vector<u16> builder;
builder.ensure_capacity(bytes.size());
for (auto byte : bytes.bytes())
builder.unchecked_append(byte);
return MUST(Utf16View { builder }.to_utf8(Utf16View::AllowInvalidCodeUnits::Yes));
}
VERIFY_NOT_REACHED();
}