mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 11:36:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Keep harfbuzz hb_buffer instead of reallocating every time

Browse source 
Easy 1% speed-up on Speedometer 3.
This commit is contained in:
Andreas Kling 2025-04-18 17:15:37 +02:00 • committed by Andreas Kling
parent 5df3838a80
commit ed5ad267c7
Notes: github-actions[bot] 2025-04-18 23:15:00 +00:00
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibGfx/TextLayout.cpp
View file

@ -14,8 +14,7 @@ namespace Gfx {
RefPtr<GlyphRun> shape_text(FloatPoint baseline_start, float letter_spacing, Utf8View string, Gfx::Font const& font, GlyphRun::TextType text_type, ShapeFeatures const& features)
{
hb_buffer_t* buffer = hb_buffer_create();
ScopeGuard destroy_buffer = [&]() { hb_buffer_destroy(buffer); };
static hb_buffer_t* buffer = hb_buffer_create();
hb_buffer_add_utf8(buffer, reinterpret_cast<char const*>(string.bytes()), string.byte_length(), 0, -1);
hb_buffer_guess_segment_properties(buffer);
@ -60,9 +59,9 @@ RefPtr<GlyphRun> shape_text(FloatPoint baseline_start, float letter_spacing, Utf
point.translate_by(letter_spacing, 0);
}
auto run = adopt_ref(*new Gfx::GlyphRun(move(glyph_run), font, text_type, point.x()));
hb_buffer_reset(buffer);
return adopt_ref(*new Gfx::GlyphRun(move(glyph_run), font, text_type, point.x()));
return run;
}
float measure_text_width(Utf8View const& string, Gfx::Font const& font, ShapeFeatures const& features)