mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-16 23:31:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibJS: Add Value::{is, as}_function()

Browse source
This commit is contained in:
Linus Groh 2020-05-06 11:52:53 +01:00 • committed by Andreas Kling
parent 419bce6915
commit eea62dd365
Notes: sideshowbarker 2024-07-19 06:56:23 +09:00
6 changed files with 26 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibJS/Runtime/ReflectObject.cpp
View file

@ -47,11 +47,11 @@ static Object* get_target_object_from(Interpreter& interpreter, const String& na
static Function* get_target_function_from(Interpreter& interpreter, const String& name)
{
auto target = interpreter.argument(0);
if (!target.is_object() || !target.as_object().is_function()) {
if (!target.is_function()) {
interpreter.throw_exception<TypeError>(String::format("First argument of Reflect.%s() must be a function", name.characters()));
return nullptr;
}
return static_cast<Function*>(&target.as_object());
return &target.as_function();
}
static void prepare_arguments_list(Interpreter& interpreter, Value value, MarkedValueList* arguments)
@ -121,13 +121,12 @@ Value ReflectObject::construct(Interpreter& interpreter)
auto* new_target = target;
if (interpreter.argument_count() > 2) {
auto new_target_value = interpreter.argument(2);
if (!new_target_value.is_object()
|| !new_target_value.as_object().is_function()
if (!new_target_value.is_function()
|| (new_target_value.as_object().is_native_function() && !static_cast<NativeFunction&>(new_target_value.as_object()).has_constructor())) {
interpreter.throw_exception<TypeError>("Optional third argument of Reflect.construct() must be a constructor");
return {};
}
new_target = static_cast<Function*>(&new_target_value.as_object());
new_target = &new_target_value.as_function();
}
return interpreter.construct(*target, *new_target, move(arguments));
}