mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-29 13:46:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Everywhere: Remove sv suffix from format string literals

Browse source 
This prevents the compile-time checks that would catch errors in the
format invocation (which would usually lead to a runtime crash).
This commit is contained in:
Timothy Flynn 2025-04-08 13:50:50 -04:00 • committed by Tim Flynn
commit f070264800
Notes: github-actions[bot] 2025-04-09 00:01:12 +00:00
28 changed files with 51 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibCrypto/Certificate/Certificate.cpp
View file

@ -51,7 +51,7 @@ static ErrorOr<AlgorithmIdentifier> parse_algorithm_identifier(ASN1::Decoder& de
// algorithm ALGORITHM.&id({SupportedAlgorithms}),
// parameters ALGORITHM.&Type({SupportedAlgorithms}{@algorithm}) OPTIONAL,
// ... }
ENTER_TYPED_SCOPE(Sequence, "AlgorithmIdentifier"sv);
ENTER_TYPED_SCOPE(Sequence, "AlgorithmIdentifier");
PUSH_SCOPE("algorithm"sv);
READ_OBJECT(ObjectIdentifier, Vector<int>, algorithm);
POP_SCOPE();
@ -192,7 +192,7 @@ ErrorOr<SubjectPublicKey> parse_subject_public_key_info(ASN1::Decoder& decoder,
// }
SubjectPublicKey public_key;
ENTER_TYPED_SCOPE(Sequence, "SubjectPublicKeyInfo"sv);
ENTER_TYPED_SCOPE(Sequence, "SubjectPublicKeyInfo");
public_key.algorithm = TRY(parse_algorithm_identifier(decoder, current_scope));
@ -258,7 +258,7 @@ ErrorOr<PrivateKey> parse_private_key_info(ASN1::Decoder& decoder, Vector<String
// }
PrivateKey private_key;
ENTER_TYPED_SCOPE(Sequence, "PrivateKeyInfo"sv);
ENTER_TYPED_SCOPE(Sequence, "PrivateKeyInfo");
READ_OBJECT(Integer, Crypto::UnsignedBigInteger, version);
if (version != 0) {

6
Libraries/LibCrypto/PK/EC.cpp
View file

@ -81,7 +81,7 @@ ErrorOr<EC::KeyPairType> EC::parse_ec_key(ReadonlyBytes der, bool is_private, Ve
// publicKey [1] BIT STRING OPTIONAL
// }
ENTER_TYPED_SCOPE(Sequence, "ECPrivateKey"sv);
ENTER_TYPED_SCOPE(Sequence, "ECPrivateKey");
PUSH_SCOPE("version");
READ_OBJECT(Integer, Crypto::UnsignedBigInteger, version);
@ -98,7 +98,7 @@ ErrorOr<EC::KeyPairType> EC::parse_ec_key(ReadonlyBytes der, bool is_private, Ve
auto tag = TRY(decoder.peek());
if (static_cast<u8>(tag.kind) == 0) {
REWRITE_TAG(Sequence);
ENTER_TYPED_SCOPE(Sequence, "parameters"sv);
ENTER_TYPED_SCOPE(Sequence, "parameters");
parameters = TRY(Crypto::Certificate::parse_ec_parameters(decoder, {}));
EXIT_SCOPE();
}
@ -109,7 +109,7 @@ ErrorOr<EC::KeyPairType> EC::parse_ec_key(ReadonlyBytes der, bool is_private, Ve
auto tag = TRY(decoder.peek());
if (static_cast<u8>(tag.kind) == 1) {
REWRITE_TAG(Sequence);
ENTER_TYPED_SCOPE(Sequence, "publicKey"sv);
ENTER_TYPED_SCOPE(Sequence, "publicKey");
READ_OBJECT(BitString, Crypto::ASN1::BitStringView, public_key_bits);
auto public_key_bytes = TRY(public_key_bits.raw_bytes());

4
Libraries/LibCrypto/PK/RSA.cpp
View file

@ -43,7 +43,7 @@ ErrorOr<RSA::KeyPairType> RSA::parse_rsa_key(ReadonlyBytes der, bool is_private,
// otherPrimeInfos OtherPrimeInfos OPTIONAL
// }
ENTER_TYPED_SCOPE(Sequence, "RSAPrivateKey"sv);
ENTER_TYPED_SCOPE(Sequence, "RSAPrivateKey");
PUSH_SCOPE("version");
READ_OBJECT(Integer, Crypto::UnsignedBigInteger, version);
@ -104,7 +104,7 @@ ErrorOr<RSA::KeyPairType> RSA::parse_rsa_key(ReadonlyBytes der, bool is_private,
// publicExponent INTEGER
// }
ENTER_TYPED_SCOPE(Sequence, "RSAPublicKey"sv);
ENTER_TYPED_SCOPE(Sequence, "RSAPublicKey");
PUSH_SCOPE("modulus");
READ_OBJECT(Integer, Crypto::UnsignedBigInteger, modulus);