mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Make unknown webkit pseudo-elements safe to dump

Browse source 
This fixes a couple of crashes when dumping the style sheets on
ladybird.org
This commit is contained in:
Sam Atkins 2025-05-08 11:48:34 +01:00
commit f0ce4f43a6
Notes: github-actions[bot] 2025-05-08 15:22:46 +00:00
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Dump.cpp
View file

@ -590,7 +590,7 @@ void dump_selector(StringBuilder& builder, CSS::Selector const& selector, int in
if (simple_selector.type == CSS::Selector::SimpleSelector::Type::PseudoElement) {
auto const& pseudo_element = simple_selector.pseudo_element();
builder.appendff(" pseudo_element={}", CSS::pseudo_element_name(pseudo_element.type()));
builder.appendff(" pseudo_element={}", pseudo_element.serialize());
auto pseudo_element_metadata = CSS::pseudo_element_metadata(pseudo_element.type());
switch (pseudo_element_metadata.parameter_type) {

7
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSPseudoElement.cpp
View file

@ -525,8 +525,13 @@ PseudoElementMetadata pseudo_element_metadata(PseudoElement pseudo_element)
});
generator.append(R"~~~(
case PseudoElement::KnownPseudoElementCount:
case PseudoElement::UnknownWebKit:
return {
.parameter_type = PseudoElementMetadata::ParameterType::None,
.is_valid_as_function = false,
.is_valid_as_identifier = true,
};
case PseudoElement::KnownPseudoElementCount:
break;
}
VERIFY_NOT_REACHED();