mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 12:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Resolve performance FIXME in Node::is_equal_node()

Browse source
This commit is contained in:
Jelle Raaijmakers 2024-12-18 14:07:40 +01:00 • committed by Tim Ledbetter
parent c357fbf036
commit f29457b61e
Notes: github-actions[bot] 2024-12-18 23:47:21 +00:00
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/DOM/Node.cpp
View file

@ -1793,20 +1793,19 @@ bool Node::is_equal_node(Node const* other_node) const
}
// A and B have the same number of children.
size_t this_child_count = child_count();
size_t other_child_count = other_node->child_count();
if (this_child_count != other_child_count)
if (child_count() != other_node->child_count())
return false;
// Each child of A equals the child of B at the identical index.
// FIXME: This can be made nicer. child_at_index() is O(n).
for (size_t i = 0; i < this_child_count; ++i) {
auto* this_child = child_at_index(i);
auto* other_child = other_node->child_at_index(i);
VERIFY(this_child);
auto* this_child = first_child();
auto* other_child = other_node->first_child();
while (this_child) {
VERIFY(other_child);
if (!this_child->is_equal_node(other_child))
return false;
this_child = this_child->next_sibling();
other_child = other_child->next_sibling();
}
return true;