mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-08 04:02:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Rename Window::open_impl() to Window::window_open_steps()

Browse source 
This is the same name used in the specification.
This commit is contained in:
Tim Ledbetter 2024-10-20 10:32:37 +01:00 • committed by Tim Ledbetter
parent b999f925dc
commit f3c6326f27
Notes: github-actions[bot] 2024-10-20 10:43:18 +00:00
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -680,7 +680,7 @@ WebIDL::ExceptionOr<JS::GCPtr<HTML::WindowProxy>> Document::open(StringView url,
return WebIDL::InvalidAccessError::create(realm(), "Cannot perform open on a document that isn't fully active."_string);
// 2. Return the result of running the window open steps with url, name, and features.
return window()->open_impl(url, name, features);
return window()->window_open_steps(url, name, features);
}
// https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#closing-the-input-stream

4
Userland/Libraries/LibWeb/HTML/Window.cpp
View file

@ -139,7 +139,7 @@ void Window::finalize()
Window::~Window() = default;
// https://html.spec.whatwg.org/multipage/window-object.html#window-open-steps
WebIDL::ExceptionOr<JS::GCPtr<WindowProxy>> Window::open_impl(StringView url, StringView target, StringView features)
WebIDL::ExceptionOr<JS::GCPtr<WindowProxy>> Window::window_open_steps(StringView url, StringView target, StringView features)
{
// 1. If the event loop's termination nesting level is nonzero, return null.
if (main_thread_event_loop().termination_nesting_level() != 0)
@ -1007,7 +1007,7 @@ JS::GCPtr<DOM::Element const> Window::frame_element() const
WebIDL::ExceptionOr<JS::GCPtr<WindowProxy>> Window::open(Optional<String> const& url, Optional<String> const& target, Optional<String> const& features)
{
// The open(url, target, features) method steps are to run the window open steps with url, target, and features.
return open_impl(*url, *target, *features);
return window_open_steps(*url, *target, *features);
}
// https://html.spec.whatwg.org/multipage/system-state.html#dom-navigator

2
Userland/Libraries/LibWeb/HTML/Window.h
View file

@ -101,7 +101,7 @@ public:
bool import_maps_allowed() const { return m_import_maps_allowed; }
void set_import_maps_allowed(bool import_maps_allowed) { m_import_maps_allowed = import_maps_allowed; }
WebIDL::ExceptionOr<JS::GCPtr<WindowProxy>> open_impl(StringView url, StringView target, StringView features);
WebIDL::ExceptionOr<JS::GCPtr<WindowProxy>> window_open_steps(StringView url, StringView target, StringView features);
bool has_animation_frame_callbacks() const { return m_animation_frame_callback_driver.has_callbacks(); }
DOM::Event* current_event() { return m_current_event.ptr(); }