From f3f7f77dbc5a32f19069ef347b3ce5dc36525351 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 2 Oct 2024 13:39:55 -0400 Subject: [PATCH] LibWeb: Wait for the correct condition in Stream tests We were signaling that the test is complete too early in some Stream tests. --- .../input/Streams/ReadableStream-pipeThrough.html | 12 +++++------- .../Text/input/Streams/ReadableStream-pipeTo.html | 9 ++++++--- .../Text/input/Streams/WritableStream-write.html | 5 ++++- 3 files changed, 15 insertions(+), 11 deletions(-) diff --git a/Tests/LibWeb/Text/input/Streams/ReadableStream-pipeThrough.html b/Tests/LibWeb/Text/input/Streams/ReadableStream-pipeThrough.html index dbb55131ee1..d22944c7acb 100644 --- a/Tests/LibWeb/Text/input/Streams/ReadableStream-pipeThrough.html +++ b/Tests/LibWeb/Text/input/Streams/ReadableStream-pipeThrough.html @@ -39,19 +39,17 @@ cancel() {}, }); - const reader = transformStream.readable.getReader(); - reader.read().then(function processText({done, value}) { - if (done) + reader.read().then(function processText(result) { + if (result.done) { + done(); return; + } - println(value); + println(result.value); reader.read().then(processText); - }).then(() => { - done(); }); stream.pipeThrough(transformStream); - }); diff --git a/Tests/LibWeb/Text/input/Streams/ReadableStream-pipeTo.html b/Tests/LibWeb/Text/input/Streams/ReadableStream-pipeTo.html index f689398566d..e73143a86b3 100644 --- a/Tests/LibWeb/Text/input/Streams/ReadableStream-pipeTo.html +++ b/Tests/LibWeb/Text/input/Streams/ReadableStream-pipeTo.html @@ -11,8 +11,13 @@ return new Promise((resolve) => { const textDecoder = new TextDecoder("utf-8"); println(textDecoder.decode(new Uint8Array(chunk))); + resolve(); }); + }, + + close() { + done(); } } ); @@ -40,8 +45,6 @@ cancel() {}, }); - stream.pipeTo(writableStream).then(() => { - done(); - }); + stream.pipeTo(writableStream); }); diff --git a/Tests/LibWeb/Text/input/Streams/WritableStream-write.html b/Tests/LibWeb/Text/input/Streams/WritableStream-write.html index 6c0239bf2e4..9ac9202305a 100644 --- a/Tests/LibWeb/Text/input/Streams/WritableStream-write.html +++ b/Tests/LibWeb/Text/input/Streams/WritableStream-write.html @@ -8,6 +8,10 @@ resolve(); }); }, + + close() { + done(); + } }); function sendMessage(message) { @@ -19,7 +23,6 @@ writer.ready.then(() => { writer.close(); - done(); }); }