mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-24 18:02:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Disable optimization in IteratorNextUnpack if next() is redefined
Some checks are pending
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
81b6a11 regressed correctness by always bypassing the `next()` method
resolution for built-in iterators, causing incorrect behavior when
`next()` was redefined on built-in prototypes. This change fixes the
issue by storing a flag on built-in prototypes indicating whether
`next()` has ever been redefined.
This commit is contained in:
Aliaksandr Kalenik 2025-05-12 04:27:25 +03:00 • committed by Alexander Kalenik
parent a6d9e8acd8
commit f405d71657
Notes: github-actions[bot] 2025-05-12 11:42:25 +00:00
18 changed files with 151 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Runtime/StringIterator.cpp
View file

@ -7,6 +7,7 @@
#include <AK/Utf8View.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/StringIterator.h>
#include <LibJS/Runtime/StringIteratorPrototype.h>
namespace JS {
@ -22,6 +23,8 @@ StringIterator::StringIterator(String string, Object& prototype)
, m_string(move(string))
, m_iterator(Utf8View(m_string).begin())
{
auto& string_iterator_prototype = as<StringIteratorPrototype>(prototype);
m_next_method_was_redefined = string_iterator_prototype.next_method_was_redefined();
}
ThrowCompletionOr<void> StringIterator::next(VM& vm, bool& done, Value& value)