Meta: Restore default "build everything" behavior in ladybird.py
Some checks are pending
Push notes / build (push) Waiting to run
CI / Lagom (arm64, Sanitizer_CI, false, macOS, macos-15, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, Linux, blacksmith-16vcpu-ubuntu-2404, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, Linux, blacksmith-16vcpu-ubuntu-2404, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, Linux, blacksmith-16vcpu-ubuntu-2404, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macOS, macOS-universal2, macos-15) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, Linux, Linux-x86_64, blacksmith-8vcpu-ubuntu-2404) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run

By default, we want `ladybird.py build` to build everything. We were
previously defaulting to only building the Ladybird target.

We now only fall back to the Ladybird target for commands that run a
program. So `ladybird.py run` will build and run Ladybird.
This commit is contained in:
Timothy Flynn 2025-05-29 13:47:03 -04:00 committed by Tim Flynn
commit f46f9b0f02
Notes: github-actions[bot] 2025-05-29 23:34:44 +00:00

View file

@ -47,7 +47,7 @@ def main():
compiler_parser.add_argument("--cxx", required=False, default=default_cxx)
target_parser = argparse.ArgumentParser(add_help=False)
target_parser.add_argument("target", nargs=argparse.OPTIONAL, default="Ladybird")
target_parser.add_argument("target", nargs=argparse.OPTIONAL)
build_parser = subparsers.add_parser(
"build", help="Compiles the target binaries", parents=[preset_parser, compiler_parser, target_parser]
@ -122,6 +122,8 @@ def main():
if args.target == "ladybird":
args.target = "Ladybird"
if not args.target and args.command not in ("build", "rebuild"):
args.target = "Ladybird"
(cc, cxx) = pick_host_compiler(platform, args.cc, args.cxx)