From f48b760011b656871f861c23a68b07c778f3d114 Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Sat, 19 Apr 2025 17:05:40 +1200 Subject: [PATCH] LibWeb/CSS: Avoid URL validity check parsing CSS URLs --- Libraries/LibWeb/CSS/Parser/Parser.cpp | 4 ++-- Libraries/LibWeb/CSS/Parser/Parser.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibWeb/CSS/Parser/Parser.cpp b/Libraries/LibWeb/CSS/Parser/Parser.cpp index 7f28578dc5a..a5b1a36d41d 100644 --- a/Libraries/LibWeb/CSS/Parser/Parser.cpp +++ b/Libraries/LibWeb/CSS/Parser/Parser.cpp @@ -1871,9 +1871,9 @@ bool Parser::is_parsing_svg_presentation_attribute() const // FIXME: URLs shouldn't be completed during parsing, but when used. Optional<::URL::URL> Parser::complete_url(StringView relative_url) const { - if (!m_url.is_valid()) + if (!m_url.has_value()) return ::URL::Parser::basic_parse(relative_url); - return m_url.complete_url(relative_url); + return m_url->complete_url(relative_url); } } diff --git a/Libraries/LibWeb/CSS/Parser/Parser.h b/Libraries/LibWeb/CSS/Parser/Parser.h index 11cc431a390..086f75f204a 100644 --- a/Libraries/LibWeb/CSS/Parser/Parser.h +++ b/Libraries/LibWeb/CSS/Parser/Parser.h @@ -477,7 +477,7 @@ private: GC::Ptr m_document; GC::Ptr m_realm; - ::URL::URL m_url; + Optional<::URL::URL> m_url; ParsingMode m_parsing_mode { ParsingMode::Normal }; Vector m_tokens;