mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-24 08:59:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't pass unnecessary PropertyComputationDependencies struct

Browse source 
Since we now have access to the `AbstractElement` through the
`ComputationContext` we can just set the flag that this element relies
on tree counting functions directly, no need to pass this struct around.
This commit is contained in:
Callum Law 2025-10-22 00:48:32 +13:00 • committed by Jelle Raaijmakers
commit f49cf75d44
Notes: github-actions[bot] 2025-10-21 23:01:59 +00:00
40 changed files with 200 additions and 249 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibWeb/CSS/ParsedFontFace.cpp
View file

@ -89,10 +89,8 @@ ParsedFontFace ParsedFontFace::from_descriptors(CSSFontFaceDescriptors const& de
if (value->to_keyword() == Keyword::Auto) {
weight = 400;
} else {
// NOTE: We can disregard the dependencies here because they won't change
PropertyComputationDependencies property_computation_dependencies;
// NOTE: The value we pass here for inherited_font_weight is irrelevant as relative keywords (lighter, bolder) should be disallowed at parse time
weight = StyleComputer::compute_font_weight(*value, 0, computation_context, property_computation_dependencies)->as_number().number();
weight = StyleComputer::compute_font_weight(*value, 0, computation_context)->as_number().number();
}
}
@ -105,9 +103,7 @@ ParsedFontFace ParsedFontFace::from_descriptors(CSSFontFaceDescriptors const& de
if (value->to_keyword() == Keyword::Auto) {
slope = 0;
} else {
// NOTE: We can disregard the dependencies here because they won't change
PropertyComputationDependencies property_computation_dependencies;
slope = StyleComputer::compute_font_style(*value, computation_context, property_computation_dependencies)->as_font_style().to_font_slope();
slope = StyleComputer::compute_font_style(*value, computation_context)->as_font_style().to_font_slope();
}
}
@ -120,9 +116,7 @@ ParsedFontFace ParsedFontFace::from_descriptors(CSSFontFaceDescriptors const& de
if (value->to_keyword() == Keyword::Auto) {
width = 100;
} else {
// NOTE: We can disregard the dependencies here because they won't change
PropertyComputationDependencies property_computation_dependencies;
width = StyleComputer::compute_font_width(*value, computation_context, property_computation_dependencies)->as_percentage().raw_value();
width = StyleComputer::compute_font_width(*value, computation_context)->as_percentage().raw_value();
}
}