mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 21:59:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Rename Element::shadow_root_internal() to shadow_root()

Browse source 
And let the old shadow_root(), which was only supposed to be used by
bindings, be called shadow_root_for_bindings() instead.

This makes it much easier to read DOM code, and we don't have to worry
about when to use shadow_root_internal() or why.
This commit is contained in:
Andreas Kling 2024-06-25 11:28:58 +02:00 • committed by Andreas Kling
commit f4bdf56212
Notes: sideshowbarker 2024-07-17 17:06:59 +09:00
18 changed files with 27 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/HTMLProgressElement.cpp
View file

@ -97,7 +97,7 @@ void HTMLProgressElement::removed_from(DOM::Node*)
void HTMLProgressElement::create_shadow_tree_if_needed()
{
if (shadow_root_internal())
if (shadow_root())
return;
auto shadow_root = heap().allocate<DOM::ShadowRoot>(realm(), document(), *this, Bindings::ShadowRootMode::Closed);