mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-06 17:11:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Throw error on insertRule with disallowed @namespace rule

Browse source 
Resolves a FIXME in `CSSRuleList::insert_a_css_rule`. Gets us a bit
closer to passing https://wpt.live/css/cssom/at-namespace.html but that
requires more work around parsing of selectors with namespaces (namely
disallowing use of undeclared selectors), which I have added a FIXME
for.
This commit is contained in:
Callum Law 2025-06-09 22:33:36 +12:00 • committed by Sam Atkins
parent 3421cd76fa
commit f53bec3a67
Notes: github-actions[bot] 2025-06-09 10:57:43 +00:00
4 changed files with 36 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/CSS/CSSRuleList.cpp
View file

@ -92,7 +92,9 @@ WebIDL::ExceptionOr<unsigned> CSSRuleList::insert_a_css_rule(Variant<StringView,
// FIXME: 6. If new rule cannot be inserted into list at the zero-index position index due to constraints specified by CSS, then throw a HierarchyRequestError exception. [CSS21] // FIXME: 6. If new rule cannot be inserted into list at the zero-index position index due to constraints specified by CSS, then throw a HierarchyRequestError exception. [CSS21]
// FIXME: 7. If new rule is an @namespace at-rule, and list contains anything other than @import at-rules, and @namespace at-rules, throw an InvalidStateError exception. // 7. If new rule is an @namespace at-rule, and list contains anything other than @import at-rules, and @namespace at-rules, throw an InvalidStateError exception.
if (new_rule->type() == CSSRule::Type::Namespace && any_of(m_rules, [](auto existing_rule) { return existing_rule->type() != CSSRule::Type::Import && existing_rule->type() != CSSRule::Type::Namespace; }))
return WebIDL::InvalidStateError::create(realm(), "Cannot insert @namespace rule into a stylesheet with non-namespace/import rules"_string);
// 8. Insert new rule into list at the zero-indexed position index. // 8. Insert new rule into list at the zero-indexed position index.
m_rules.insert(index, *new_rule); m_rules.insert(index, *new_rule);

3
Libraries/LibWeb/CSS/Parser/SelectorParsing.cpp
View file

@ -258,6 +258,9 @@ Optional<Selector::SimpleSelector::QualifiedName> Parser::parse_selector_qualifi
? Selector::SimpleSelector::QualifiedName::NamespaceType::Any ? Selector::SimpleSelector::QualifiedName::NamespaceType::Any
: Selector::SimpleSelector::QualifiedName::NamespaceType::Named; : Selector::SimpleSelector::QualifiedName::NamespaceType::Named;
// FIXME: https://www.w3.org/TR/selectors-4/#invalid
// - a simple selector containing an undeclared namespace prefix is invalid
transaction.commit(); transaction.commit();
return Selector::SimpleSelector::QualifiedName { return Selector::SimpleSelector::QualifiedName {
.namespace_type = namespace_type, .namespace_type = namespace_type,

2
Tests/LibWeb/Text/expected/css/namespace-rules.txt Normal file
View file

@ -0,0 +1,2 @@
Can insert namespace rule into sheet with only @namespace and @import rules: PASS
Cannot insert namespace rule into sheet with existing rules: PASS

28
Tests/LibWeb/Text/input/css/namespace-rules.html Normal file
View file

@ -0,0 +1,28 @@
<!DOCTYPE html>
<style id="a">
@namespace my_namespace_1 url("http://www.w3.org/1999/xhtml");
@import url("nonexist.css");
</style>
<style id="b">
div {
color: green;
}
</style>
<script src="../include.js"></script>
<script>
test(() => {
try {
a.sheet.insertRule('@namespace my_namespace_3 url("http://www.w3.org/1999/xhtml")', 0);
println("Can insert namespace rule into sheet with only @namespace and @import rules: PASS");
} catch {
println("Can insert namespace rule into sheet with only @namespace and @import rules: FAIL");
}
try {
s.sheet.insertRule('@namespace my_namespace_3 url("http://www.w3.org/1999/xhtml")', 0);
println("Cannot insert namespace rule into sheet with existing rules: FAIL");
} catch {
println("Cannot insert namespace rule into sheet with existing rules: PASS");
}
});
</script>