mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-16 21:20:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Allow setting shorthand values with StylePropertyMap.set()

Browse source 
Shorthands should be broken up into their longhands, instead of setting
them directly.

There's a catch here with our "positional value list shorthands" like
`margin`: Setting margin to a single value like `CSSUnitValue(10, "px")`
is supposed to fail here, but our type-checking code thinks it's valid
because our JSON for `margin` says it accepts lengths. This is the same
kind of issue that we had for `cursor` discussed in the
"LibWeb/CSS: Support converting CSSUnitValue to a StyleValue" commit.

Will get us a few subtest passes for every shorthand that's tested.
This commit is contained in:
Sam Atkins 2025-10-03 14:57:42 +01:00 • committed by Andreas Kling
commit f61c67792d
Notes: github-actions[bot] 2025-10-09 14:16:45 +00:00
6 changed files with 233 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Libraries/LibWeb/CSS/CSSStyleProperties.cpp
View file

@ -419,13 +419,25 @@ WebIDL::ExceptionOr<void> CSSStyleProperties::set_property_style_value(PropertyN
return {};
}
m_properties.remove_first_matching([&property](StyleProperty const& style_property) {
return style_property.property_id == property.id();
});
m_properties.append(StyleProperty {
.important = Important::No,
.property_id = property.id(),
.value = move(style_value),
// FIXME: This should have been rejected earlier, but property_accepts_type() is too basic for what we need.
if (property_is_positional_value_list_shorthand(property.id())
&& !style_value->is_shorthand()
&& !style_value->is_unresolved()
&& !style_value->is_pending_substitution()
&& !style_value->is_guaranteed_invalid()
&& !style_value->is_css_wide_keyword()) {
return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, MUST(String::formatted("Setting {} to '{}' is not allowed.", property.name(), style_value->to_string(SerializationMode::Normal))) };
}
StyleComputer::for_each_property_expanding_shorthands(property.id(), style_value, [this](PropertyID longhand_id, StyleValue const& longhand_value) {
m_properties.remove_first_matching([longhand_id](StyleProperty const& style_property) {
return style_property.property_id == longhand_id;
});
m_properties.append(StyleProperty {
.important = Important::No,
.property_id = longhand_id,
.value = longhand_value,
});
});
return {};